Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite of MCLC #124

Open
wants to merge 98 commits into
base: master
Choose a base branch
from
Open

Rewrite of MCLC #124

wants to merge 98 commits into from

Conversation

PadowYT2
Copy link

@PadowYT2 PadowYT2 commented Mar 11, 2024 •
edited
Loading

This Pull Request has a lot of changes

  • Usage of
    • Typescript (which translates into ESM and CJS during building)
    • Vitest
    • ESLint
    • Prettier
    • Yarn (instead of npm)
  • Many functions were completly remade to work with TS and just function
  • Removed Auth functions

There are still things to finish, such as

  • Config
  • Tests
  • README
  • GitHub workflows
    • Vitest
    • Prettier

@PadowYT2
Testing conditions
7efae84
@PadowYT2
Multiple initial changes
d2bc16f 
- Use yarn
- Reconfigure eslint
- Install prettier and format the code
@PadowYT2
Add progress to testing
998eab9
@PadowYT2
components -> src
db98c90
@PadowYT2
[AUTH] Rewrite request into axios
16aa00b
@PadowYT2
Finish rewriting request into axios
1a66368
@PadowYT2
Remove the need for checksum package
f30266a
@PadowYT2
Fully remove checksum
1fa2d38
@PadowYT2
Support ESM (WIP, need to convert into TS to support both)
d6652d3
@PadowYT2
Preparations for rewriting to TS
57237b0
@PadowYT2
[WIP] Recode into TS
4f6b2f0
@PadowYT2
'config' is never reassigned
273c0d2
@PadowYT2
Fix logging
57232bc
@PadowYT2
Fixed some things about the memory
c054a07
@PadowYT2
Update handler.ts
946e95d
@PadowYT2
Unbundle launch to install and start
86d1775
@PadowYT2
Fix having MC the MCLC prefix
0db2b49
@PadowYT2
Fix MC not properly downloading natives on Windows
72458b9
@PadowYT2
Bring back java check
f8cff87
@PadowYT2
Uncomment this also
84f6cef
@PadowYT2
[WIP] Forge installer
70f518c
@PadowYT2
[WIP] Forge instlaler
73f6e0b
@PadowYT2
Remove forge mod loader
d69c475
@PadowYT2
Finish all mod loaders (except Neoforge)
c8bdb0e
@PadowYT2
Some outside of code changes
2cd8142
@PadowYT2
Remove cheerio
e501da1
@PadowYT2
Remove Java check on installation
0831ef5
@PadowYT2
Vanilla testing
65e52b2
@PadowYT2
Whoops
6dffaab
@PadowYT2
Legacy and modern versions testing
7d1ba38
@PadowYT2 PadowYT2 marked this pull request as ready for review May 7, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bricklou Bricklou Bricklou requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PadowYT2 @Bricklou