-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tidb): checkout to minor version of tidb-test for hotfix #3321
base: main
Are you sure you want to change the base?
fix(tidb): checkout to minor version of tidb-test for hotfix #3321
Conversation
Signed-off-by: purelind <[email protected]>
Based on the pull request title and description, the changes are made to the From the diff, it looks like the changes are adding some conditional logic to checkout the specific branch ( However, there are a couple of suggestions for improvement:
Other than that, the pull request looks good. |
Signed-off-by: purelind <[email protected]>
Based on the PR title and description, the key change in this PR is to checkout the corresponding minimum version of the tidb-test code for a specific hotfix branch. The changes in the code are related to handling the case when a branch or commit sha is specified in the PR title. One potential problem is that the current code assumes that a branch or commit sha is specified in multiple PR titles during hotfix branch batch merge. This may lead to errors if the branch or commit sha is not specified in the PR title or the specified branch or commit sha is incorrect. To fix this, the code logic should be updated to more clearly handle the case when a branch or commit sha is specified in the PR title. Also, the error handling should be improved to prevent any incorrect assumptions about the specified branches or commit shas. Additionally, some code comments or documentation can be added to explain the changes in this PR and provide more context for future code maintainers. |
/hold Need to test different situations to see if they meet expectations. |
Signed-off-by: purelind <[email protected]>
Based on the pull request, the key change is to checkout the corresponding minimum version of the tidb-test code for the hotfix branch. The code changes are mostly related to validating and filtering tidb-test refs. There are no potential problems in this pull request. However, I would suggest adding more comments to explain the changes and improve the readability of the code. Additionally, it is always a good practice to run unit tests and integration tests before merging the changes. |
Signed-off-by: purelind <[email protected]>
Key changes:
Potential problems:
Fixing suggestions:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/hold please rename the |
For the hotfix branch(example release-8.5-20250114-v8.5.0), we need to checkout the corresponding minimum version of the tidb-test code (release-8.5.0).