-
Notifications
You must be signed in to change notification settings - Fork 0
Fix/시간대 조정 버그 수정 #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
The head ref may contain hidden characters: "fix/\uC2DC\uAC04\uB300-\uC870\uC815-\uBC84\uADF8-\uC218\uC815"
Merged
Fix/시간대 조정 버그 수정 #18
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 0 additions & 39 deletions
39
src/main/java/me/gg/pinit/pinittask/interfaces/web/MemberController.java
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
169 changes: 0 additions & 169 deletions
169
src/main/java/me/gg/pinit/pinittask/interfaces/web/ScheduleController.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
문제점: getScheduleList 메서드가 클라이언트로부터 받은 ZonedDateTime의 시간대를 무시하고, DB에서 조회한 사용자의 시간대(memberZoneById)를 사용하여 날짜 범위를 계산하고 있습니다.
영향: 클라이언트가 전달한 시간대 정보가 무시되어, 서로 다른 시간대에서 같은 날짜를 요청해도 동일한 결과가 반환됩니다. 예를 들어, 사용자가 여행 중 다른 시간대에 있을 때 의도한 날짜의 일정을 조회하지 못할 수 있습니다.
수정 제안: dateTime 파라미터의 시간대를 사용하여 날짜 범위를 계산하거나, memberZoneById만 사용할 것이라면 파라미터로 LocalDate만 받도록 변경하는 것이 좋습니다.