-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/긴급도 레벨 제거 및 난이도 레벨 추가 #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
The head ref may contain hidden characters: "feat/\uAE34\uAE09\uB3C4-\uB808\uBCA8-\uC81C\uAC70-\uBC0F-\uB09C\uC774\uB3C4-\uB808\uBCA8-\uCD94\uAC00"
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8359e41
feat: 긴급도 레벨 제거 및 난이도 레벨 추가
GoGradually fdaa5f5
feat: 긴급도 레벨 제거 및 난이도 레벨 추가
GoGradually df07227
feat: 긴급도 레벨을 난이도 레벨로 변경
GoGradually 36e9aa9
feat: 긴급도 레벨을 난이도 레벨로 변경
GoGradually ac6e293
test: 긴급도 레벨을 난이도 레벨로 변경하는 테스트 수정
GoGradually 2fd8955
feat: 긴급도 레벨을 난이도 레벨로 변경
GoGradually f48881a
docs: README에서 긴급도 레벨을 난이도 레벨로 변경
GoGradually 9e7a1b9
feat: 난이도 레벨의 최대값을 9에서 21로 변경
GoGradually 8320993
feat: 중요도 및 난이도 레벨 검증 추가
GoGradually 1894fe4
test: 허용되지 않은 난이도 레벨에 대한 예외 처리 테스트 추가
GoGradually File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(1) 문제점: 새로운 난이도 검증 로직(
validateDifficultyLevel)과changeDifficultyLevel메서드에 대한 테스트 커버리지가 없습니다.(2) 영향: 피보나치 수열 검증이 제대로 작동하는지 확인할 수 없으며, 유효하지 않은 값(예: 4, 6, 7, 9 등)이 입력되었을 때 예외가 올바르게 발생하는지 검증되지 않습니다.
(3) 수정 제안: 다음 테스트 케이스를 추가해야 합니다:
changeDifficultyLevel메서드의 정상 동작 테스트