-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Trengo internal notes #17600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Trengo internal notes #17600
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
components/trengo/actions/create-internal-note/create-internal-note.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
import app from "../../trengo.app.mjs"; | ||
|
||
export default { | ||
type: "action", | ||
key: "trengo-create-internal-note", | ||
version: "0.0.1", | ||
name: "Create Internal Note", | ||
description: "Create an internal note on a ticket that is only visible to team members. [See the docs](https://developers.trengo.com/reference/create-internal-note)", | ||
props: { | ||
app, | ||
ticketId: { | ||
propDefinition: [ | ||
app, | ||
"ticketId", | ||
], | ||
}, | ||
note: { | ||
propDefinition: [ | ||
app, | ||
"note", | ||
], | ||
optional: false, | ||
description: "The internal note content that will be added to the ticket.", | ||
}, | ||
}, | ||
async run({ $ }) { | ||
const resp = await this.app.createInternalNote({ | ||
$, | ||
data: { | ||
ticket_id: this.ticketId, | ||
note: this.note, | ||
}, | ||
}); | ||
$.export("$summary", `Successfully created internal note on ticket ${this.ticketId}`); | ||
return resp; | ||
}, | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: Missing ticket_id for internal note creation.
Internal notes must be associated with a ticket, but no
ticket_id
is being passed to thecreateInternalNote
method. This will likely cause API errors since the/tickets/notes
endpoint requires knowing which ticket to attach the note to.Additionally, the metadata structure being passed is inconsistent with the dedicated
create-internal-note
action which only passesticket_id
andnote
.Consider one of these solutions:
ticketId
prop to this action whencreateInternalNote
is truecreate-internal-note
action/tickets/notes
endpoint📝 Committable suggestion
🤖 Prompt for AI Agents