17406 components indiefunnels #17619
Conversation
Sources - New Booking Session (Instant) - New Form Submission (Instant) - New Order (Instant) - Contact Updated (Instant) Actions - Create Contact - Update Contact - Create Member - Update Member
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThis update introduces a comprehensive IndieFunnels integration, adding four actions (create/update contact and member) and four webhook-based sources (booking session, form submission, order, and contact update). It implements utility functions, a constants file, and a fully-featured IndieFunnels app module with async option loaders, API methods, and property definitions. Supporting test event fixtures are also included. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Action/Source
participant IndieFunnels App
participant IndieFunnels API
User->>Action/Source: Trigger action or webhook source
Action/Source->>IndieFunnels App: Call API method (e.g., createContact, updateMember)
IndieFunnels App->>IndieFunnels API: HTTP request (create/update/contact/member/webhook)
IndieFunnels API-->>IndieFunnels App: API response
IndieFunnels App-->>Action/Source: Return result or emit event
Action/Source-->>User: Output response or event data
Assessment against linked issues
Suggested labels
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/indiefunnels/indiefunnels.app.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/indiefunnels/sources/common/base.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used🧠 Learnings (1)components/indiefunnels/indiefunnels.app.mjs (9)⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (3)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (9)
components/indiefunnels/sources/new-order-instant/test-event.mjs (1)
1-74: Replace tab indents with 2-space indents to match component style guideAll other IndieFunnels component files use 2-space indentation. Mixing tabs and spaces hurts diff readability and violates the repo’s style convention.
components/indiefunnels/package.json (1)
12-17: Package metadata solid, but consider addingtype:"module"Since every file is
.mjs, declaring"type": "module"avoids any ambiguity when consumers import this package.components/indiefunnels/sources/contact-updated-instant/test-event.mjs (1)
19-22: Minor data realism nit – use non-zero subscriber list id
0is usually a sentinel / invalid id in many systems. Using1(or another positive id) makes the fixture look more realistic and avoids confusion in tests that might treat0as falsy.components/indiefunnels/actions/create-member/create-member.mjs (1)
177-205: Consider nested object cleaning for address objects.The
cleanObjfunction is applied to the entire data object, but the nestedbillingAddressandshippingAddressobjects might contain empty/undefined values that won't be cleaned. Consider applyingcleanObjto these nested objects as well.data: cleanObj({ name: this.name, email: this.email, groups: this.groups, approved: this.approved, contactId: this.contactId, - billingAddress: { + billingAddress: cleanObj({ phone: this.billingPhone, companyName: this.billingCompanyName, companyId: this.billingCompanyId, country: this.billingCountry, state: this.billingState, city: this.billingCity, zipCode: this.billingZipCode, address: this.billingAddress, address2: this.billingAddress2, - }, + }), - shippingAddress: { + shippingAddress: cleanObj({ phone: this.shippingPhone, companyName: this.shippingCompanyName, companyId: this.shippingCompanyId, country: this.shippingCountry, state: this.shippingState, city: this.shippingCity, zipCode: this.shippingZipCode, address: this.shippingAddress, address2: this.shippingAddress2, - }, + }), }),components/indiefunnels/sources/new-form-submission-instant/new-form-submission-instant.mjs (1)
18-20: Consider adding null safety for nested property access.The
getSummarymethod accesseswebsite.systemDomainwithout checking ifwebsiteexists, which could cause runtime errors if the webhook payload structure changes.- getSummary({ website }) { - return `New form submission from website: ${website.systemDomain}`; + getSummary({ website }) { + return `New form submission from website: ${website?.systemDomain || 'Unknown'}`;components/indiefunnels/actions/update-contact/update-contact.mjs (1)
121-126: Add null safety for props.email access.The
additionalPropsmethod accessesprops.email.defaultwithout checking ifprops.emailexists, which could cause runtime errors.async additionalProps(props) { - if (this.contactId) { + if (this.contactId && props.email) { props.email.default = this.contactId.label; } return {}; },components/indiefunnels/indiefunnels.app.mjs (3)
47-76: Consider adding pagination for groups and subscriber lists.The
groupsandsubscriberListsoptions load all items without pagination, which could cause performance issues with large datasets.Consider implementing pagination similar to other options:
async options() { - const items = await this.listMemberGroups(); + const { items } = await this.listMemberGroups({ + params: { + limit: LIMIT, + skip: 0, // Load first page only for options + }, + });
127-132: Provide structure documentation for custom properties.The
propertiesfield accepts an object but lacks documentation about expected structure or examples.Update the description to include expected format:
properties: { type: "object", label: "Properties", - description: "An object of custom properties, as defined in the CRM section in your website", + description: "An object of custom properties, as defined in the CRM section in your website. Example: `{\"customField1\": \"value1\", \"customField2\": \"value2\"}`", },
331-336: Add opts parameter to deleteHook for consistency.The
deleteHookmethod doesn't accept additional options like other API methods, which breaks consistency.-deleteHook(webhookId) { +deleteHook(webhookId, opts = {}) { return this._makeRequest({ method: "DELETE", path: `/webhooks/${webhookId}`, + ...opts, }); },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (17)
components/indiefunnels/actions/create-contact/create-contact.mjs(1 hunks)components/indiefunnels/actions/create-member/create-member.mjs(1 hunks)components/indiefunnels/actions/update-contact/update-contact.mjs(1 hunks)components/indiefunnels/actions/update-member/update-member.mjs(1 hunks)components/indiefunnels/common/constants.mjs(1 hunks)components/indiefunnels/common/utils.mjs(1 hunks)components/indiefunnels/indiefunnels.app.mjs(1 hunks)components/indiefunnels/package.json(2 hunks)components/indiefunnels/sources/common/base.mjs(1 hunks)components/indiefunnels/sources/contact-updated-instant/contact-updated-instant.mjs(1 hunks)components/indiefunnels/sources/contact-updated-instant/test-event.mjs(1 hunks)components/indiefunnels/sources/new-booking-session-instant/new-booking-session-instant.mjs(1 hunks)components/indiefunnels/sources/new-booking-session-instant/test-event.mjs(1 hunks)components/indiefunnels/sources/new-form-submission-instant/new-form-submission-instant.mjs(1 hunks)components/indiefunnels/sources/new-form-submission-instant/test-event.mjs(1 hunks)components/indiefunnels/sources/new-order-instant/new-order-instant.mjs(1 hunks)components/indiefunnels/sources/new-order-instant/test-event.mjs(1 hunks)
🧰 Additional context used
🧠 Learnings (15)
components/indiefunnels/sources/contact-updated-instant/test-event.mjs (3)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: In the Salesloft API integration (components/salesloft/salesloft.app.mjs), the _makeRequest method returns response.data which directly contains arrays for list endpoints like listPeople, listCadences, listUsers, and listAccounts. The propDefinitions correctly call .map() directly on these responses without needing to destructure a nested data property.
components/indiefunnels/package.json (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
components/indiefunnels/sources/new-form-submission-instant/test-event.mjs (4)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: In the Salesloft API integration (components/salesloft/salesloft.app.mjs), the _makeRequest method returns response.data which directly contains arrays for list endpoints like listPeople, listCadences, listUsers, and listAccounts. The propDefinitions correctly call .map() directly on these responses without needing to destructure a nested data property.
components/indiefunnels/sources/new-booking-session-instant/test-event.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
components/indiefunnels/actions/create-contact/create-contact.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/indiefunnels/sources/new-booking-session-instant/new-booking-session-instant.mjs (4)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
components/indiefunnels/sources/new-form-submission-instant/new-form-submission-instant.mjs (4)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
components/indiefunnels/actions/create-member/create-member.mjs (3)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
components/indiefunnels/sources/new-order-instant/test-event.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
components/indiefunnels/sources/new-order-instant/new-order-instant.mjs (5)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common.mjs:97-98
Timestamp: 2024-07-24T02:05:59.531Z
Learning: The `processTimerEvent` method in the `components/salesforce_rest_api/sources/common.mjs` file is intentionally left unimplemented to enforce that subclasses must implement this method, similar to an abstract class in object-oriented programming.
components/indiefunnels/actions/update-contact/update-contact.mjs (2)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
components/indiefunnels/actions/update-member/update-member.mjs (3)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/indiefunnels/sources/common/base.mjs (3)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
components/indiefunnels/sources/contact-updated-instant/contact-updated-instant.mjs (4)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
components/indiefunnels/indiefunnels.app.mjs (4)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: In the Salesloft API integration (components/salesloft/salesloft.app.mjs), the _makeRequest method returns response.data which directly contains arrays for list endpoints like listPeople, listCadences, listUsers, and listAccounts. The propDefinitions correctly call .map() directly on these responses without needing to destructure a nested data property.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: The Salesloft API list endpoints (listPeople, listCadences, listUsers, listAccounts) return arrays directly in the response body, not wrapped in a metadata object with a nested data property. The _makeRequest method correctly returns response.data which contains the arrays that can be mapped over directly in propDefinitions.
🪛 Biome (1.9.4)
components/indiefunnels/common/utils.mjs
[error] 37-37: Avoid the use of spread (...) syntax on accumulators.
Spread syntax should be avoided on accumulators (like those in .reduce) because it causes a time complexity of O(n^2).
Consider methods such as .splice or .push instead.
(lint/performance/noAccumulatingSpread)
🔇 Additional comments (16)
components/indiefunnels/common/constants.mjs (1)
1-1: Constant looks goodSingle-source export is clean and self-describing.
No action needed.components/indiefunnels/sources/new-form-submission-instant/test-event.mjs (2)
1-45: LGTM! Well-structured test event data.The test event structure appropriately models a form submission with website details, contact information, form name, and form values. The data structure follows a logical pattern for webhook event testing.
20-20: Verify the timestamp value.The
createdOntimestamp (1752521431) corresponds to a date in 2025. Ensure this future timestamp is intentional for testing purposes.components/indiefunnels/sources/new-booking-session-instant/new-booking-session-instant.mjs (1)
1-24: LGTM! Standard source component implementation.The component correctly extends the common base module, defines the appropriate event type, and implements the required methods following the established pattern for webhook sources.
components/indiefunnels/actions/create-member/create-member.mjs (1)
174-210: LGTM! Comprehensive member creation implementation.The action properly handles extensive member properties including billing and shipping addresses, uses the cleanObj utility appropriately, and follows the standard action pattern.
components/indiefunnels/sources/contact-updated-instant/contact-updated-instant.mjs (1)
1-24: LGTM! Standard source component implementation.The component correctly extends the common base module, defines the appropriate event type for contact updates, and implements the required methods following the established pattern. The naming convention is correct for update events.
components/indiefunnels/actions/create-contact/create-contact.mjs (2)
110-138: LGTM! Well-implemented contact creation action.The action properly handles contact properties including complex objects like properties, tags, and subscriber lists. The properties transformation logic correctly converts key-value pairs to the expected API format with name-value objects.
122-128: Excellent property transformation logic.The properties transformation properly converts the parsed object into the expected API format using
Object.entries()and mapping to name-value pairs.components/indiefunnels/sources/new-order-instant/new-order-instant.mjs (1)
1-23: LGTM! Well-structured webhook source component.The component correctly extends the common base and implements the required methods for a webhook source. The event type "order_created" aligns with the component's purpose, and the summary generation is properly implemented.
components/indiefunnels/sources/new-form-submission-instant/new-form-submission-instant.mjs (1)
1-23: LGTM! Consistent webhook source implementation.The component follows the established pattern and correctly implements the required methods for form submission events.
components/indiefunnels/common/utils.mjs (1)
1-24: LGTM! Well-implemented JSON parsing utility with proper error handling.The
parseObjectfunction handles arrays and strings appropriately with try-catch blocks for JSON parsing errors.components/indiefunnels/actions/update-contact/update-contact.mjs (1)
1-156: LGTM! Well-structured contact update action with proper data transformation.The action correctly uses utility functions to clean and parse input data, properly transforms properties into the expected API format, and provides appropriate feedback.
components/indiefunnels/actions/update-member/update-member.mjs (1)
1-211: LGTM! Well-organized member update action with proper data structuring.The action correctly organizes the member data into nested billing and shipping address objects, uses the cleanObj utility to remove empty values, and provides appropriate feedback.
components/indiefunnels/sources/common/base.mjs (2)
1-9: Well-structured webhook source base module.The imports and props follow standard Pipedream webhook source patterns correctly.
26-34: Add webhook payload verification or confirm security approach with IndieFunnels supportWe weren’t able to find any official signature header for IndieFunnels webhooks in the public docs. To ensure your handler is secure:
- Confirm with IndieFunnels support whether they provide a signature header (e.g.
X-IndieFunnels-Signature) or plan to add one.- If no native support exists, implement an alternative verification strategy:
- Validate a shared secret sent in a custom header or payload field
- Whitelist incoming IP ranges for IndieFunnels
- Use a timestamp + HMAC stored in your database
Update
components/indiefunnels/sources/common/base.mjsaccordingly:// components/indiefunnels/sources/common/base.mjs async run({ body }) { + // TODO: verify webhook payload before proceeding + // Example stub—adjust once IndieFunnels support details are confirmed: + // const secret = this.db.get('webhookSecret'); + // const signature = headers['x-indiefunnels-signature']; + // if (!validateHMAC(body, signature, secret)) { + // throw new Error('Invalid webhook signature'); + // } const ts = body.created || Date.now(); this.$emit(body, { id: `${body.id}-${ts}`, summary: this.getSummary(body), ts, }); },Please reach out to IndieFunnels support to verify their webhook security mechanism and implement the appropriate verification logic.
components/indiefunnels/indiefunnels.app.mjs (1)
1-7: Proper app module structure and imports.The module setup follows Pipedream app standards correctly.
components/indiefunnels/sources/new-booking-session-instant/test-event.mjs
Show resolved
Hide resolved
Resolves #17406
Summary by CodeRabbit
New Features
Improvements
Chores