[FIX] Fireflies issue with New Meeting Created source

[jcortes]

WHY

Resolves #18879

Summary by CodeRabbit

• New Features

  • Transcript queries now support pagination (fromDate, limit, skip) for finer result control
  • Automatic date initialization added for meeting tracking during deployment

• Bug Fixes

  • Improved timestamp handling in meeting event processing for more accurate results

• Chores

  • Bumped component versions and updated platform dependency for compatibility

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Preview	Comments	Updated (UTC)
pipedream-docs	Ignored			Nov 6, 2025 5:05pm
pipedream-docs-redirect-do-not-edit	Ignored			Nov 6, 2025 5:05pm

[coderabbitai]

Walkthrough

Version bumps across several Fireflies actions and source; GraphQL transcript query extended for pagination; a deploy hook was added to initialize last-processed date and timestamp handling adjusted in the new-meeting-created source.

Changes

Cohort / File(s)	Summary
Action version updates components/fireflies/actions/find-meeting-by-id/find-meeting-by-id.mjs, components/fireflies/actions/find-recent-meeting/find-recent-meeting.mjs, components/fireflies/actions/upload-audio/upload-audio.mjs	Bumped exported version values: two actions from 0.0.3 → 0.0.4, one action from 0.0.4 → 0.0.5. No other logic changes.
Source: deploy hook & timestamp handling components/fireflies/sources/new-meeting-created/new-meeting-created.mjs	Bumped version 0.0.3 → 0.0.4; added hooks.deploy to initialize lastDate to one day ago; changed timestamp generation from Date.parse(result.date) to result.date; updated query variable from date to fromDate (ISO string).
GraphQL query (pagination) components/fireflies/common/queries.mjs	listTranscriptsByDate / Transcripts query signature changed from accepting a single date to ($fromDate: DateTime, $limit: Int, $skip: Int) and now calls transcripts(fromDate: $fromDate, limit: $limit, skip: $skip) enabling pagination.
Package metadata components/fireflies/package.json	Component version bumped 0.1.3 → 0.1.4; dependency @pipedream/platform updated ^3.0.3 → ^3.1.0.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant Deployer as Deploy event
    participant Hook as hooks.deploy
    participant DB as DB (lastDate)
    participant Source as new-meeting-created source
    participant API as Fireflies GraphQL

    Deployer->>Hook: run deploy hook
    Hook->>DB: set lastDate = now - 1 day
    DB-->>Hook: ack
    Hook-->>Source: ready

    Note right of Source: Poll loop uses DB.lastDate as fromDate
    Source->>DB: read lastDate
    Source->>API: query Transcripts(fromDate, limit, skip)
    API-->>Source: transcripts[]
    Source->>Source: generateMeta(ts = result.date)
    Source->>DB: update lastDate

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Files/areas to focus on:
  • components/fireflies/sources/new-meeting-created/new-meeting-created.mjs — correctness of hooks.deploy initialization, format of result.date vs. previous Date.parse usage, and migration to fromDate variable.
  • components/fireflies/common/queries.mjs — ensure caller sites and pagination logic use new fromDate, limit, skip variables and that types/formats match GraphQL expectations.
  • components/fireflies/package.json — confirm @pipedream/platform bump is compatible with code changes (minor).

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title clearly indicates a fix for the Fireflies New Meeting Created source, directly matching the primary change objective.
Description check	✅ Passed	The PR description is minimal but complete, containing the required WHY section with a link to the resolved issue.
Linked Issues check	✅ Passed	Code changes address the core issue: added deploy hook to initialize lastDate, updated query parameters from date to fromDate with ISO string formatting, and added pagination support.
Out of Scope Changes check	✅ Passed	All changes are scoped to Fireflies integration: version bumps, query signature updates for pagination, deploy hook initialization, and parameter refactoring to resolve the null lastDate polling issue.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-fireflies-new-meeting-created

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c6db12b and 199f655.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (6)

• components/fireflies/actions/find-meeting-by-id/find-meeting-by-id.mjs (1 hunks)
• components/fireflies/actions/find-recent-meeting/find-recent-meeting.mjs (1 hunks)
• components/fireflies/actions/upload-audio/upload-audio.mjs (1 hunks)
• components/fireflies/common/queries.mjs (2 hunks)
• components/fireflies/package.json (2 hunks)
• components/fireflies/sources/new-meeting-created/new-meeting-created.mjs (2 hunks)

🧰 Additional context used

🧠 Learnings (2)

📚 Learning: 2025-10-20T01:01:02.970Z

Learnt from: js07
Repo: PipedreamHQ/pipedream PR: 18744
File: components/slack_v2/actions/send-large-message/send-large-message.mjs:49-64
Timestamp: 2025-10-20T01:01:02.970Z
Learning: In components/slack_v2/actions/send-large-message/send-large-message.mjs, the metadata_event_payload prop is typed as string, so the code only needs to handle string-to-JSON parsing and does not need to handle object inputs.

Applied to files:

• components/fireflies/actions/upload-audio/upload-audio.mjs

📚 Learning: 2024-12-12T19:23:09.039Z

Learnt from: jcortes
Repo: PipedreamHQ/pipedream PR: 14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.

Applied to files:

• components/fireflies/package.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Publish TypeScript components
• GitHub Check: Verify TypeScript components
• GitHub Check: Lint Code Base

🔇 Additional comments (9)

components/fireflies/actions/upload-audio/upload-audio.mjs (1)

8-8: Version bump acknowledged.

Part of the coordinated release for this PR. No functional changes detected.

components/fireflies/actions/find-meeting-by-id/find-meeting-by-id.mjs (1)

9-9: Version bump acknowledged.

Part of the coordinated release for this PR. No functional changes detected.

components/fireflies/actions/find-recent-meeting/find-recent-meeting.mjs (1)

9-9: Version bump acknowledged.

Part of the coordinated release for this PR. No functional changes detected.

components/fireflies/sources/new-meeting-created/new-meeting-created.mjs (4)

11-11: Version bump acknowledged.

Part of the coordinated release for this PR.

---

46-51: Excellent fix for the null lastDate issue.

The deploy hook properly initializes lastDate to one day ago, which directly addresses the reported problem where db.get("lastDate") was returning null and preventing new events from being detected.

---

56-59: Parameter rename aligns correctly with the updated GraphQL query.

The change from date to fromDate matches the query signature update in components/fireflies/common/queries.mjs.

---

42-42: No conversion needed—result.date is already in milliseconds.

The Fireflies GraphQL API returns the date field as a number type, and the API documentation confirms that date values are provided in milliseconds (e.g., 1621292557453). The test event file shows "date": 1713201000000, confirming this format. The current code ts: result.date is correct and requires no modification.

Likely an incorrect or invalid review comment.

components/fireflies/common/queries.mjs (1)

10-37: GraphQL query signature update looks correct.

The parameter rename from $date to $fromDate improves clarity, and the pagination support via limit and skip aligns with the usage in components/fireflies/sources/new-meeting-created/new-meeting-created.mjs. The query structure and field selection remain appropriate.

components/fireflies/package.json (1)

3-3: No breaking changes found in @pipedream/platform v3.1.0 upgrade.

The web search found no published changelog entry or release notes that list breaking changes for @pipedream/platform v3.1.0. Given that the version bump is a minor version increment (3.0.3 → 3.1.0), semver conventions indicate backward compatibility is maintained. The upgrade is safe to proceed with.

[luancazarine]

Hi @jcortes, LGTM! Ready for QA!

[vunguyenhung]

For Integration QA:

• Source Test Report: https://www.notion.so/Fireflies-Sources-2a3bf548bb5e81cda998dcc7189778d9

[vunguyenhung]

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check test reports below for more information:

• Fireflies - Actions Batch 1: https://www.notion.so/Fireflies-Actions-Batch-1-1-2a3bf548bb5e81cbbb2fd76cb7fb3539
• Fireflies - Sources: https://www.notion.so/Fireflies-Sources-2a3bf548bb5e81cda998dcc7189778d9