CVE-2007-4559 Patch

keras/mlflow/model/pipeline_train.py

@@ -111,7 +111,26 @@ def download_input():
     import tarfile
     print("decompressing flower_photos.tgz to '{}'".format(os.path.abspath("flower_photos")))
     with tarfile.open("flower_photos.tgz") as tar:
-        tar.extractall(path="./")
+        def is_within_directory(directory, target):
+
+            abs_directory = os.path.abspath(directory)
+            abs_target = os.path.abspath(target)
+
+            prefix = os.path.commonprefix([abs_directory, abs_target])
+
+            return prefix == abs_directory
+
+        def safe_extract(tar, path=".", members=None, *, numeric_owner=False):
+
+            for member in tar.getmembers():
+                member_path = os.path.join(path, member.name)
+                if not is_within_directory(path, member_path):
+                    raise Exception("Attempted Path Traversal in Tar File")
+
+            tar.extractall(path, members, numeric_owner=numeric_owner) 
+
+
+        safe_extract(tar, path="./")
 
 
 @click.command(help="Trains an Keras model on flower_photos dataset."

keras/mnist-privacy/model/privacy/research/pate_2018/ICLR2018/download.py

@@ -32,7 +32,26 @@ def download():
   tar_filename, _ = urllib.request.urlretrieve(FILE_URI)
   print('Unpacking ' + tar_filename)
   with tarfile.open(tar_filename, "r:gz") as tar:
-    tar.extractall(DATA_DIR)
+    def is_within_directory(directory, target):
+
+        abs_directory = os.path.abspath(directory)
+        abs_target = os.path.abspath(target)
+
+        prefix = os.path.commonprefix([abs_directory, abs_target])
+
+        return prefix == abs_directory
+
+    def safe_extract(tar, path=".", members=None, *, numeric_owner=False):
+
+        for member in tar.getmembers():
+            member_path = os.path.join(path, member.name)
+            if not is_within_directory(path, member_path):
+                raise Exception("Attempted Path Traversal in Tar File")
+
+        tar.extractall(path, members, numeric_owner=numeric_owner) 
+
+
+    safe_extract(tar, DATA_DIR)
   print('Done!')
 
 

keras/mnist-v1/model/official/transformer/data_download.py

@@ -196,7 +196,26 @@ def download_and_extract(path, url, input_filename, target_filename):
   # Extract compressed files
   tf.logging.info("Extracting %s." % compressed_file)
   with tarfile.open(compressed_file, "r:gz") as corpus_tar:
-    corpus_tar.extractall(path)
+    def is_within_directory(directory, target):
+
+        abs_directory = os.path.abspath(directory)
+        abs_target = os.path.abspath(target)
+
+        prefix = os.path.commonprefix([abs_directory, abs_target])
+
+        return prefix == abs_directory
+
+    def safe_extract(tar, path=".", members=None, *, numeric_owner=False):
+
+        for member in tar.getmembers():
+            member_path = os.path.join(path, member.name)
+            if not is_within_directory(path, member_path):
+                raise Exception("Attempted Path Traversal in Tar File")
+
+        tar.extractall(path, members, numeric_owner=numeric_owner) 
+
+
+    safe_extract(corpus_tar, path)
 
   # Return filepaths of the requested files.
   input_file = find_file(path, input_filename)

tensorflow/mnist-raw/model/official/transformer/data_download.py

@@ -196,7 +196,26 @@ def download_and_extract(path, url, input_filename, target_filename):
   # Extract compressed files
   tf.logging.info("Extracting %s." % compressed_file)
   with tarfile.open(compressed_file, "r:gz") as corpus_tar:
-    corpus_tar.extractall(path)
+    def is_within_directory(directory, target):
+
+        abs_directory = os.path.abspath(directory)
+        abs_target = os.path.abspath(target)
+
+        prefix = os.path.commonprefix([abs_directory, abs_target])
+
+        return prefix == abs_directory
+
+    def safe_extract(tar, path=".", members=None, *, numeric_owner=False):
+
+        for member in tar.getmembers():
+            member_path = os.path.join(path, member.name)
+            if not is_within_directory(path, member_path):
+                raise Exception("Attempted Path Traversal in Tar File")
+
+        tar.extractall(path, members, numeric_owner=numeric_owner) 
+
+
+    safe_extract(corpus_tar, path)
 
   # Return filepaths of the requested files.
   input_file = find_file(path, input_filename)

tensorflow/mnist-retrain/model/official/transformer/data_download.py

@@ -195,7 +195,26 @@ def download_and_extract(path, url, input_filename, target_filename):
   # Extract compressed files
   tf.logging.info("Extracting %s." % compressed_file)
   with tarfile.open(compressed_file, "r:gz") as corpus_tar:
-    corpus_tar.extractall(path)
+    def is_within_directory(directory, target):
+
+        abs_directory = os.path.abspath(directory)
+        abs_target = os.path.abspath(target)
+
+        prefix = os.path.commonprefix([abs_directory, abs_target])
+
+        return prefix == abs_directory
+
+    def safe_extract(tar, path=".", members=None, *, numeric_owner=False):
+
+        for member in tar.getmembers():
+            member_path = os.path.join(path, member.name)
+            if not is_within_directory(path, member_path):
+                raise Exception("Attempted Path Traversal in Tar File")
+
+        tar.extractall(path, members, numeric_owner=numeric_owner) 
+
+
+    safe_extract(corpus_tar, path)
 
   # Return filepaths of the requested files.
   input_file = find_file(path, input_filename)

tensorflow/mnist-v1/model/official/transformer/data_download.py

@@ -196,7 +196,26 @@ def download_and_extract(path, url, input_filename, target_filename):
   # Extract compressed files
   tf.logging.info("Extracting %s." % compressed_file)
   with tarfile.open(compressed_file, "r:gz") as corpus_tar:
-    corpus_tar.extractall(path)
+    def is_within_directory(directory, target):
+
+        abs_directory = os.path.abspath(directory)
+        abs_target = os.path.abspath(target)
+
+        prefix = os.path.commonprefix([abs_directory, abs_target])
+
+        return prefix == abs_directory
+
+    def safe_extract(tar, path=".", members=None, *, numeric_owner=False):
+
+        for member in tar.getmembers():
+            member_path = os.path.join(path, member.name)
+            if not is_within_directory(path, member_path):
+                raise Exception("Attempted Path Traversal in Tar File")
+
+        tar.extractall(path, members, numeric_owner=numeric_owner) 
+
+
+    safe_extract(corpus_tar, path)
 
   # Return filepaths of the requested files.
   input_file = find_file(path, input_filename)