Repository navigation
fix: coerce numeric string scores in normalizeEvent - #39
Closed
Pitchfork-and-Torch wants to merge 2 commits into
Closed
Pitchfork-and-Torch wants to merge 2 commits into
Pitchfork-and-Torch wants to merge 2 commits into
Conversation
…mmand Nexus, sealed replay, Home Shield, Merkle forensics.
Number.isFinite rejects string scores such as \"5\", so JSON/hub callers silently fell back to type-derived scores. Coerce non-empty numeric strings before the finite check, matching timestamp handling.
Pitchfork-and-Torch
force-pushed
the
main
branch
from
September 18, 2026 04:29
4198fb6 to
d37d430
Compare
Pitchfork-and-Torch
deleted the
cook/normalize-event-numeric-string-score
branch
September 18, 2026 04:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
normalizeEventusedNumber.isFinite(raw.score), which rejects numeric strings such as"5".Distinct from #30–#38 (chain skip, loadConfig, verifyLedger corrupt, non-finite scores, finite numeric ts, readEvents/readLedger limit, verifyLedger maxEntries, numeric string timestamps).
Test plan
node test/normalize-event-numeric-string-score.jsnode test/normalize-event-score.jsnode test/normalize-event-numeric-string-ts.jsnode test/normalize-event-ts.js