Repository navigation
Beta v0.11.0 - #186
Merged
timothymillar merged 15 commits intoSep 22, 2025
Merged
Beta v0.11.0#186timothymillar merged 15 commits into
timothymillar merged 15 commits into
Conversation
timothymillar
force-pushed
the
flat-genotype-prior
branch
from
September 22, 2025 03:44
2b76234 to
aec0526
Compare
timothymillar
merged commit Sep 22, 2025
5c4d3a1
into
Plant-Food-Research-Open:master
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change:
assembleto a flat prior across genotypes.This is a more sensible prior in almost all situations because the previous
Dirichlet-multinomial prior had to assume that all possible haplotypes (i.e.,
combinations of SNVS) where equally likely to be present in the sample population.
In general, this inflated the prior probability of heterozygous genotypes.
Note that this is not a significant issue when using the
callprogram withknown haplotypes (and a reasonable estimate of their frequencies).
The previous Dirichlet-multinomial prior can still be used via the
--use-dirmul-priorargument. Consider defaulting flat prior across genotypes #139callandcall-exactto a flat prior acrossgenotypes. This is a better default option than the previous Dirichlet-multinomial
prior when sample inbreeding and prior allele frequencies are not specified.
The previous Dirichlet-multinomial prior can still be used via the
--use-dirmul-priorargument which is now used to set both the sample inbreeding and prior on allele
frequencies. This new argument replaces the
--inbreedingand--prior-frequenciesarguments. Consider defaulting flat prior across genotypes #139