Switch compute from recursive to looped

desc/compute/__init__.py

@@ -43,7 +43,7 @@
     _stability,
     _surface,
 )
-from .data_index import all_kwargs, allowed_kwargs, data_index
+from .data_index import _topological_order, all_kwargs, allowed_kwargs, data_index
 from .utils import (
     compute,
     get_data_deps,
@@ -143,6 +143,7 @@ def _collect_deps(p, all_deps):
         # The deps are stored in topological order (not alphabetical) so that
         # iterating over them computes quantities in valid dependency order.
         topo_index = {key: i for i, key in enumerate(order)}
+        _topological_order[p] = topo_index
         for key in order:
             d = data_index[p][key]
             deps_info = d["dependencies"]
@@ -211,30 +212,3 @@ def _collect_deps(p, all_deps):
 
 
 _build_data_index()
-
-
-def set_tier(name, p):
-    """Determine how deep in the dependency tree a given name is.
-
-    tier of 0 means no dependencies on other data,
-    tier of 1 means it depends on only tier 0 stuff,
-    tier of 2 means it depends on tier 0 and tier 1, etc etc.
-
-    Designed such that if you compute things in the order determined by tiers,
-    all dependencies will always be computed in the correct order.
-    """
-    if "tier" in data_index[p][name]:
-        return
-    if len(data_index[p][name]["full_with_axis_dependencies"]["data"]) == 0:
-        data_index[p][name]["tier"] = 0
-    else:
-        thistier = 0
-        for name1 in data_index[p][name]["full_with_axis_dependencies"]["data"]:
-            set_tier(name1, p)
-            thistier = max(thistier, data_index[p][name1]["tier"])
-        data_index[p][name]["tier"] = thistier + 1
-
-
-for par in data_index.keys():
-    for name in data_index[par]:
-        set_tier(name, par)

desc/compute/data_index.py

@@ -287,6 +287,7 @@ def _decorator(func):
     ],
     "desc.magnetic_fields._core.OmnigenousField": [],
 }
+_topological_order = {}
 data_index = {p: {} for p in _class_inheritance.keys()}
 all_kwargs = {p: {} for p in _class_inheritance.keys()}
 allowed_kwargs = {"basis"}