-
Notifications
You must be signed in to change notification settings - Fork 54
Adding QUADCOIL integration to DESC as an objective #2110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lankef
wants to merge
72
commits into
master
Choose a base branch
from
ffu/quadcoil-qss-pre-commit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
72 commits
Select commit
Hold shift + click to select a range
e930a2e
initial commit to add a quadcoil-based objective. A direct interface …
lankef 69a5e87
initial commit of the QUADCOIL objective, tweaking 2 control flows in…
lankef 74892d8
still debugging instability
lankef 395d8f9
Improving printing
6426650
Initial commit about single-stage
lankef 925e19e
fixing init
lankef 773651e
Updating QuadcoilObject
c36d534
Completing QUADCOIL single-stage interface, testing
dc6a65e
Renaming and minor bug fixes
45e88d8
Fixes for static attrs
f243182
Fixes for static attrs
59ec216
Merge remote-tracking branch 'origin/master' into ffu/quadcoil
a7c368f
Merge remote-tracking branch 'origin/master' into ffu/quadcoil
87c86e4
Merge remote-tracking branch 'origin/master' into ffu/quadcoil
7e6d350
Testing for static argument error
6507199
Fixing quadcoil
c4300f5
Adding simsopt curve conversion
c4754d4
Accommodating external fields in QuadcoilProxy
25e96af
Minor changes
3afd240
QuadcoilField first working. Adding external coil support.
e47c443
Fixing single stage. Re-organizing quadcoil-related codes to reduce c…
8d8de33
minor fix, registering quadcoilfield.
b96e3db
Fixing data_index for quadcoilfield
18e82c0
Adding conversion from QuadcoilProxy to QuadcoilField for cutting
a5455f8
Minor update. Attempting to write a quadcoil proxy-> quadcoilfield co…
1d0ff07
Minor correction, fixing coil conversion to follow simsopt updates
0ecd9f1
Merge remote-tracking branch 'origin/master' into ffu/quadcoil
b6fea15
Moving `_set_tight_layout` from line 988 to 973 to avoid RuntimeError…
8fa750d
removing quadcoil single-stage files that are immature and not ready …
7b576d1
removing quadcoil single-stage files that are immature and not ready …
218ba1a
Cleanup, completing QuadcoilProxy -> FourierCurrentPorentialField con…
312c961
Minor fix, starting documentation
778f77b
Merge remote-tracking branch 'origin/master' into ffu/quadcoil-qss-pr…
39d5bea
Adding a QUADCOIL test case. Cleaning up quadcoil integration.
06c74ff
Adding docstrings
702d446
Merge branch 'master' into ffu/quadcoil-qss-pre-commit
lankef 1cfc920
Responding to Rory Conlin's comments
66250f0
Updating docstring
61c5c12
Fixing docstring
9faf614
Add QuadcoilProxy objective to API documentation
lankef fcd9cc1
Update docstring default values for metric parameters in _quadcoil.py
lankef cf3ad2b
Renaming compute_full to solve_quadcoil and compute_surface_current_f…
13d3ad2
Merge branch 'ffu/quadcoil-qss-pre-commit' of https://github.com/Plas…
2ea1032
Merge branch 'master' into ffu/quadcoil-qss-pre-commit
YigitElma 7dfc348
Merge branch 'master' into ffu/quadcoil-qss-pre-commit
dpanici 4090f6a
a minor renaming (solve_quadcoil_surface_current_field --> solve_quad…
73a1afe
Merge branch 'ffu/quadcoil-qss-pre-commit' of https://github.com/Plas…
eaff201
Notebook update to switch from simsopt plotting to desc plotting.
90c862c
Update desc/geometry/curve.py
lankef 9871de1
formatting docstring
887dfc0
Merge branch 'ffu/quadcoil-qss-pre-commit' of https://github.com/Plas…
4942d9d
formatting warnings with f-string to improve readability. Formatting …
d947a56
moving static_attrs definitions to right after the docstring.
83c7707
Merging main changes to branch (#2290)
lankef 57b26b1
Update desc/objectives/_quadcoil.py
lankef 17c83ed
1. Removing redundant static attrs in _quadcoil.py
lankef af2e155
Merge branch 'ffu/quadcoil-qss-pre-commit' of https://github.com/Plas…
lankef 206b7c5
*may not work* removing a hacky fix in objective_funs.py
lankef 3bc0564
Fixing a KeyError
lankef fbc66b5
Merge branch 'master' into ffu/quadcoil-qss-pre-commit
lankef 926b124
Removing useless cells
lankef 41d6503
Merge branch 'master' into ffu/quadcoil-qss-pre-commit
YigitElma f8fe00e
Fixing doc issues
lankef 66e0d33
Merge branch 'ffu/quadcoil-qss-pre-commit' of https://github.com/Plas…
lankef 54744c8
revert plotting.py changes
YigitElma d449102
comment gpu line
YigitElma cb09b43
Fixing 2 unit test issues
lankef 70c041d
Merge branch 'ffu/quadcoil-qss-pre-commit' of https://github.com/Plas…
lankef 582e246
fix unit tests, clean-up
YigitElma c9ee558
Merge remote-tracking branch 'origin/master' into ffu/quadcoil-qss-pr…
YigitElma 17c9a7f
mostly cosmetic clean-ups and comments
YigitElma 8aa5ac6
Reducing notebook memory usage by reducing equilibrium resolution
lankef File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it hurts to have it, but why did you need this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default values for some QUADCOIL arguments are empty list/tuples (I had to do it because the adjoint derivative is wrapped in a vjp rule before handed to DESC and this way some flows are simpler). Without this check it breaks DESC Optimizable.