Skip to content

Commit

Permalink
Remove null default param value
Browse files Browse the repository at this point in the history
Deprecatation fix
  • Loading branch information
merwinpoulose committed Apr 4, 2023
1 parent 53a0e07 commit 51748c4
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 4 deletions.
14 changes: 12 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
{
"name": "gorriecoe/silverstripe-htmltag",
"name": "plato-creative/silverstripe-htmltag",
"description": "Provides a simply method for wrapping strings with html tags.",
"type": "silverstripe-vendormodule",
"license": "BSD-3-Clause",
"authors": [
{
"name": "Gorrie Coe",
"email": "[email protected]"
},
{
"name": "Plato Creative",
"email": "[email protected]"
}
],
"keywords": [
Expand All @@ -15,10 +19,16 @@
"templates",
"markup"
],
"homepage": "http://github.com/gorriecoe/silverstripe-htmltag",
"homepage": "http://github.com/PlatoCreative/silverstripe-htmltag",
"require": {
"silverstripe/framework": "^4"
},
"repositories": [
{
"type": "vcs",
"url": "https://github.com/PlatoCreative/silverstripe-htmltag"
}
],
"extra": {
"installer-name": "htmltag"
}
Expand Down
4 changes: 2 additions & 2 deletions src/view/HTMLTag.php
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public function setTag($tag)
* @param string $value Attribute value
* @return HTMLTag $this
*/
public function addAttribute($name = null, $value)
public function addAttribute($name, $value)
{
if ($value) {
$this->attributes[$name] = $value;
Expand All @@ -97,7 +97,7 @@ public function addAttribute($name = null, $value)
/**
* @alias addAttribute
*/
public function setAttribute($name = null, $value)
public function setAttribute($name, $value)
{
$this->addAttribute($name, $value);
return $this;
Expand Down

0 comments on commit 51748c4

Please sign in to comment.