Ajout des champs customs de l'inscription dans le form du compte utilisateur #2904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2904 +/- ##
===========================================
+ Coverage 78.43% 78.45% +0.01%
===========================================
Files 89 89
Lines 7214 7216 +2
===========================================
+ Hits 5658 5661 +3
+ Misses 1556 1555 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -138,6 +138,7 @@ def get_role(id_role): | |||
| fields = user_fields.copy() | |||
| if g.current_user == user: | |||
| fields.add("email") | |||
| fields.add("champs_addi") | |||
There was a problem hiding this comment.
C'est pas mal la protection de ne rajouter les info "confidentielles" uniquement lorsque c'est l'utilisateur lui même qui demande la route. Je rajouterais bien des tests là dessus car ça peut être un beau leak de donnée + commentaire explicite sur le pourquoi on fait ça.
Suggested change
| fields.add("champs_addi") | |
| fields.update({"email", "champs_addi"}) |
There was a problem hiding this comment.
Tu penses qu'au travers des champs addi, on puisse récupérer les mots de passes ?
jacquesfize
force-pushed
the
fix/user-conf-account-form
branch
from
e3e03eb to
a18bd6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cause d'un historique altéré, cette PR est une copie de #2737.
Cette contribution est proposée et développée par @jbrieuclp.