Configuration cleanup #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes `configure_me` do the job of reading environment variables, significantly reducing the required code. It also changes use of `String` to `PathBuf` where appropriate and removes some string manipulations.
|
Thank you for this!! I’ll merge it into v0.1.6. It’s good seeing a real world example of how to use the env part of configure_me. I wanted to use it but didn’t see it in the crate docs. I could have easily overlooked it though. |
|
Yeah, crate docs aren't that great yet. Definitely something I want to improve. |
|
I had to look it up https://docs.rs/configure_me/0.4.0/configure_me/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes
configure_medo the job of reading environmentvariables, significantly reducing the required code. It also changes use
of
StringtoPathBufwhere appropriate and removes some stringmanipulations.