Reduce dependency on FLANN, move towards nanoflann as default #6332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current behaviour: FLANN is the default search method for unorganized point clouds. If FLANN is not available, many PCL modules will not be built. Desired new behaviour (work in progress): Both FLANN and nanoflann are installed: use nanoflann as default search method for unorganized clouds (faster than FLANN) Only FLANN is installed: use FLANN as default (same as before) Only nanoflann is installed: use nanoflann as default (different than before, all PCL modules should be built, all classes should be available) Neither FLANN nor nanoflann is installed: to discuss, maybe use PCL's octree as default search method for unorganized clouds?
mvieth
added
changelog: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behaviour: FLANN is the default search method for unorganized point clouds. If FLANN is not available, many PCL modules will not be built.
Desired new behaviour (work in progress):
Both FLANN and nanoflann are installed: use nanoflann as default search method for unorganized clouds (faster than FLANN)
Only FLANN is installed: use FLANN as default (same as before)
Only nanoflann is installed: use nanoflann as default (different than before, all PCL modules should be built, all classes should be available)
Neither FLANN nor nanoflann is installed: to discuss, maybe use PCL's octree as default search method for unorganized clouds?