Skip to content

Fixed user profile page error #2618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed user profile page error #2618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/api/call.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ import { buildVariableTree, getTreeLeavesInOrder } from "./variables";
import { wrappedJsonStringify, wrappedResponseJson } from "../data/wrappedJson";
import { useAuthenticatedFetch } from "../hooks/useAuthenticatedFetch";

const POLICYENGINE_API = "https://api.policyengine.org";
const POLICYENGINE_API =
process.env.REACT_APP_API_URL || "https://api.policyengine.org";
Copy link
Collaborator

@anth-volk anth-volk Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Why add this environment variable?

Copy link
Collaborator Author

@v-lerie v-lerie Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added REACT_APP_API_URL for local development and testing. I wasn’t able to get the frontend and backend to connect properly without it. It defaults to the live API if not set, so production behavior isn’t affected. I left it in since it might be helpful for others running things locally, but I can remove it if it’s not needed.


/**
* returns an api call function that can be used to make requests
Expand Down
4 changes: 3 additions & 1 deletion src/pages/UserProfilePage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,9 @@ function UserProfileSection(props) {
} else if (dispState === STATES.EMPTY) {
dispUserSince = "Loading";
} else {
dispUserSince = dateFormatter.format(accessedUserProfile.user_since);
dispUserSince = dateFormatter.format(
new Date(parseInt(accessedUserProfile.user_since) * 1000),
Copy link
Collaborator

@anth-volk anth-volk Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question, blocking: Why multiply by 1000?

Copy link
Collaborator Author

@v-lerie v-lerie Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without multiplying by 1000, the date kept showing up as January 1st, 1970. This happened because accessedUserProfile.user_since is a Unix timestamp in seconds, but JavaScript’s Date expects timestamps in milliseconds. So we multiply by 1000 to format the date correctly.

Copy link
Collaborator

@anth-volk anth-volk Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question, blocking: But when using this code with working profiles, I'm able to properly display the date without multiplying by 1000

When we actually write the record to the table, I believe we use JS Date, not something native to the database, for this exact purpose.

);
}

let dispCountry = "";
Expand Down
Loading