Skip to content

Set benefit increases to negative values in net revenue impact table #2672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Set benefit increases to negative values in net revenue impact table #2672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
955e047
Fixed: Set benefit increases to negative values in net revenue impact…
v-lerie Jul 14, 2025
7ab4491
updated MultiYearBudgetaryImpact.test.js to expect negative benefit v…
v-lerie Jul 15, 2025
ce6734d
updated MultiYearBudgetaryImpact.test.js to expect negative benefit v…
v-lerie Jul 15, 2025
b550536
updated MultiYearBudgetaryImpact.test.js to expect negative benefit v…
v-lerie Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/__tests__/pages/policy/output/budget/MultiYearBudgetaryImpact.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,11 @@ describe("MultiYearBudgetaryImpact", () => {
expect(
screen.getByText(mockImpact.budget.budgetary_impact / 1e9),
).toBeInTheDocument();
const expectedBenefitImpact = -Math.abs(
mockImpact.budget.benefit_spending_impact / 1e9,
);
expect(
screen.getByText(mockImpact.budget.benefit_spending_impact / 1e9),
screen.getByText(expectedBenefitImpact.toString()),
).toBeInTheDocument();
expect(
screen.getByText(
Expand Down
13 changes: 10 additions & 3 deletions src/pages/policy/output/budget/MultiYearBudgetaryImpact.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,10 +114,13 @@ export default function MultiYearBudgetaryImpact(props) {
item.budgetKey ? item.budgetKey : null,
item.formula ? item.formula : null,
),

yearRange: roundToBillions(
item.budgetKey
? impact.budget[item.budgetKey]
: item.formula(impact.budget),
item.budgetKey === "benefit_spending_impact"
? -Math.abs(impact.budget[item.budgetKey])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue, blocking: I believe this only half-solves the problem

In cases where the government budget loses revenue (e.g., a new benefit program is introduced), the benefits row should be negative, but in cases where the government budget gains revenue (e.g., benefit cuts), it should be positive. This code will always make it positive.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue, blocking: It's tough to read this nested conditional

Addressing my other comment, can you modify this to be more readable/CLEAN?

: item.budgetKey
? impact.budget[item.budgetKey]
: item.formula(impact.budget),
roundingPrecisionByCountry[metadata.countryId] ||
roundingPrecisionByCountry.default,
),
Expand Down Expand Up @@ -198,6 +201,10 @@ export function getYearlyImpacts(
impact = item.result.budget[budgetKey];
}

if (budgetKey === "benefit_spending_impact") {
impact = -Math.abs(impact);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue, blocking: Here, too budgetary impacts are always negative when they should be negative only sometimes

}

yearlyImpacts[year] = roundToBillions(
impact,
roundingPrecisionByCountry[countryId] ||
Expand Down
Loading