-
Notifications
You must be signed in to change notification settings - Fork 141
Add Users page showcasing PolicyEngine user organizations #2717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Create new Users page component with responsive design - Add user data file with organizations categorized by type (government, academic, think tanks, research, advocacy) - Include organizations like Niskanen Center, JEC, NBER, Georgetown, UMich, USC, Hawaii, PN3 Policy Center, NY Senate, and Maryland Child Alliance - Add routing and navigation integration in About dropdown - Create placeholder logo assets for user organizations - Implement responsive UserCard components with hover effects - Add proper SEO meta tags and accessibility features - Follow existing codebase patterns for styling and structure Fixes #2716 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new Users page to showcase organizations that utilize PolicyEngine for policy analysis and research. The page categorizes users into government agencies, think tanks, research organizations, academic institutions, and advocacy organizations.
- Adds a comprehensive Users page with responsive design and categorized organization display
- Integrates the new page into the existing navigation structure within the About dropdown menu
- Creates a data structure to manage user organization information with logos and descriptions
Reviewed Changes
Copilot reviewed 4 out of 14 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
src/pages/Users.jsx | New page component with responsive UserCard components and categorized organization display |
src/layout/Header.jsx | Adds Users navigation item to About dropdown with appropriate icon |
src/data/users.js | Data file containing organization information, logos, and categorization |
src/PolicyEngine.jsx | Adds routing for the new Users page |
import style from "../style/index.js"; | ||
import PageHeader from "../layout/PageHeader.jsx"; | ||
import { users, userCategories } from "../data/users.js"; | ||
import useDisplayCategory from "../hooks/useDisplayCategory.js"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The useDisplayCategory
hook is imported but the component Users
is not using it. Only the UserCard
component uses this hook. Consider moving this import to the UserCard
component or removing it from the top-level imports.
import useDisplayCategory from "../hooks/useDisplayCategory.js"; |
Copilot uses AI. Check for mistakes.
style={{ | ||
color: inverted ? style.colors.WHITE : style.colors.BLUE, | ||
textDecoration: "none", | ||
}} | ||
onMouseEnter={(e) => { | ||
e.target.style.textDecoration = "underline"; | ||
}} | ||
onMouseLeave={(e) => { | ||
e.target.style.textDecoration = "none"; | ||
}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inline event handlers with style mutations can cause performance issues and make the code harder to maintain. Consider using CSS :hover pseudo-class or a proper state management approach for hover effects instead of directly manipulating the DOM.
style={{ | |
color: inverted ? style.colors.WHITE : style.colors.BLUE, | |
textDecoration: "none", | |
}} | |
onMouseEnter={(e) => { | |
e.target.style.textDecoration = "underline"; | |
}} | |
onMouseLeave={(e) => { | |
e.target.style.textDecoration = "none"; | |
}} | |
className="user-link" | |
style={{ | |
color: inverted ? style.colors.WHITE : style.colors.BLUE, | |
textDecoration: "none", | |
}} |
Copilot uses AI. Check for mistakes.
- Create UserLogosHero component with animated scrolling logo rows - Implement smooth horizontal scrolling animation using framer-motion - Add gradient overlay and centered title/subtitle overlay - Display logos in a collage pattern with multiple rows - Make responsive for mobile, tablet, and desktop views - Include blur and shadow effects for title card overlay - Replace placeholder with actual interactive logo display The hero section now shows all user organization logos in an engaging animated collage with a professional overlay displaying "Trusted by Leading Organizations" title. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Download actual JEC logo from official website - Add logos for UBI Center, Center for Growth and Opportunity, Fund for Guaranteed Income, and Mothers Outreach Network from existing orgs directory - Expand users list to include 14 total organizations across all categories - Use placeholder logos temporarily for universities (NBER, Georgetown, UMich, USC, Hawaii) and NY Senate - Update imports to use mix of users directory and existing orgs directory logos The hero section now displays all 14 user organizations including government agencies, think tanks, academic institutions, research organizations, and advocacy groups. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Update UserLogosHero to display all 14 organizations (was only showing 10) - Adjust logo rows to 5-5-4 distribution to show all logos - Make title overlay more transparent (75% opacity instead of 95%) - Reduce gap spacing between logos for better fit - Remove Student Basic Needs Coalition until proper logo is found - Fix issue with duplicate CPS placeholder logos appearing The hero section now properly displays all user organizations with improved visual transparency. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Downloaded real logos for NBER (600x400), Georgetown (180x180), and University of Michigan (2400x2400) - Used existing logos from funders for USC, Hawaii, and NY Senate as temporary replacements - Updated file imports to match correct extensions (.jpg, .jpeg) - Removed HTML error pages that were incorrectly downloaded - All 14 organizations now have distinct logos (no duplicate placeholders) Real logos obtained: - NBER: Official logo from logosvgpng.com - Georgetown: Official icon from georgetown.edu - UMich: High-res logo from logo repository - JEC, Niskanen Center, PN3Policy, MCA: Already had real logos - UBI Center, CGO, F4GI, Mothers Outreach Network: Using existing funder logos - USC, Hawaii, NY Senate: Using other org logos temporarily 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Expanded from 14 to 23 organizations, using ALL logos from UK and US homepages - Removed all placeholder logos - now using only actual organization logos - Added Arnold Ventures and Imagine LA with downloaded logos - Included all UK organizations: Centre, CPS, SMF, ASI, UKEU, NIESR, UBILabs, GPEW, Liberal Party, CEC - Included all US organizations from homepage: Niskanen, JEC, NBER, Georgetown, UMich, PN3, MCA, F4GI, Mothers Outreach, EPMT, MFB, UBI Center, CGO - Updated hero animation to continuous scrolling (no bounce back) - Adjusted layout to handle 8 logos per row on desktop, 5 on mobile - Made title overlay more transparent (75% opacity) No duplicate logos - each organization shown once with their actual logo. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…ion speeds - Added Colorado Fiscal Institute to think-tank category - Added Gary Community Ventures to advocacy category - Fixed animation speeds so all ribbons move at same speed (40s) - Using Gary Community Ventures logo as temporary placeholder for Colorado Fiscal Institute until their logo is obtained
Downloaded official logo from https://coloradofiscal.org/wp-content/uploads/2024/10/horizontal_color.webp
- Added University of Warwick to academic category - Added King's College London to academic category - Downloaded official logos from university websites - Total organizations now: 27
- Added IEA to think-tank category - IEA has used PolicyEngine for tax policy analysis including NIC changes - Downloaded official logo from their website - Total organizations now: 28
- Added Policy Simulation Library to research category - Added Beeck Center for Social Impact + Innovation to academic category - Added Better Government Lab (Georgetown-Michigan) to academic category - Using Georgetown logo as placeholder until actual logos obtained - Total organizations now: 31
… Lab - Downloaded actual logos from provided URLs - Policy Simulation Library using SVG logo - Beeck Center using official PNG logo - Better Government Lab using official PNG logo - All 31 organizations now have proper logos
Summary
Features
Implementation Details
src/pages/Users.jsx
component following existing page patternssrc/data/users.js
data file with organization informationsrc/images/logos/users/
directory (placeholder logos for now)src/PolicyEngine.jsx
src/layout/Header.jsx
Test Plan
Fixes #2716
🤖 Generated with Claude Code