Skip to content

Create independent checks for the EAEDC and TAFDC values #5916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 7, 2025

Conversation

hua7450
Copy link
Collaborator

@hua7450 hua7450 commented Apr 28, 2025

Fixes #5908

Still a draft, I will do more testing.

Copy link

codecov bot commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.10%. Comparing base (cad159e) to head (c0f5679).
Report is 16 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5916   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files        2803     2807    +4     
  Lines       40558    40601   +43     
  Branches      190      190           
=======================================
+ Hits        40195    40238   +43     
  Misses        328      328           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PavelMakarchuk PavelMakarchuk marked this pull request as ready for review April 29, 2025 17:05
Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might overlap with pavel's suggestion (started this morning)

@hua7450 hua7450 requested a review from MaxGhenis May 7, 2025 14:47
@hua7450
Copy link
Collaborator Author

hua7450 commented May 7, 2025

I also adjusted the formula for the final output formula for ma_eaedc and ma_tafdc to make them more concise.

@PavelMakarchuk PavelMakarchuk merged commit 070d6b1 into PolicyEngine:master May 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create independent checks for the EAEDC and TAFDC values
3 participants