Skip to content

Match capped value of non-refundable federal credits in state credits #5926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

PavelMakarchuk
Copy link
Collaborator

Fixes #5918

@PavelMakarchuk PavelMakarchuk marked this pull request as ready for review May 2, 2025 21:36
@PavelMakarchuk PavelMakarchuk requested a review from MaxGhenis May 2, 2025 21:36
Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please instead do #5928. Note that:

In general let's create variables for line numbers that are cited multiple times to avoid redundant code.

This will make this PR's code changes unnecessary, except for the new tests.

Then request another team member's review, I'll give the final pass.

@MaxGhenis MaxGhenis changed the title Accurately reflect non-refundable state credit matches if federal credit amounts exceed taxes Match capped value of non-refundable state credits May 3, 2025
@MaxGhenis MaxGhenis changed the title Match capped value of non-refundable state credits Match capped value of non-refundable credits in state credits May 3, 2025
@MaxGhenis MaxGhenis changed the title Match capped value of non-refundable credits in state credits Match capped value of non-refundable federal credits in state credits May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Match capped value of non-refundable federal credits in state credits
2 participants