Skip to content

Fix: remote url check #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JonathanAmenechi merged 3 commits into from
Oct 10, 2025
Merged

Fix: remote url check #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb1cbda
fix: remote url check
JonathanAmenechi Oct 10, 2025
323e805
chore: bump version
JonathanAmenechi Oct 10, 2025
fbd5fb7
chore: formating
JonathanAmenechi Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@polymarket/builder-signing-sdk",
"description": "Polymarket SDK for creating builder headers",
"version": "0.0.7",
"version": "0.0.8",
"contributors": [
{
"name": "Jonathan Amenechi",
Expand Down
17 changes: 8 additions & 9 deletions src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
import { URL } from 'url';

import { BuilderSigner } from "./signer";
import { post } from "./http-helpers";
import { BuilderApiKeyCreds, BuilderHeaderPayload, BuilderType, RemoteBuilderConfig, RemoteSignerPayload } from "./types";
import {
BuilderApiKeyCreds,
BuilderHeaderPayload,
BuilderType,
RemoteBuilderConfig,
RemoteSignerPayload
} from "./types";
import { AxiosRequestHeaders } from 'axios';

export class BuilderConfig {
Expand Down Expand Up @@ -119,12 +123,7 @@ export class BuilderConfig {

private static hasValidRemoteUrl(remoteUrl?: string): boolean {
if (!remoteUrl?.trim()) return false;
try {
const url = new URL(remoteUrl.trim());
return url.protocol === "http:" || url.protocol === "https:";
} catch {
return false;
}
return remoteUrl.startsWith("http://") || remoteUrl.startsWith("https://");
Comment thread
JonathanAmenechi marked this conversation as resolved.
Comment thread
JonathanAmenechi marked this conversation as resolved.
}

private ensureValid(): void {
Expand Down