Skip to content
Closed
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,4 @@ fastlane/report.xml
fastlane/Preview.html
fastlane/screenshots/**/*.png
fastlane/test_output
Poppool/Poppool/Infrastructure/*.mobileprovision
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ˜น์‹œ ํ”„๋กœ๋น„์ €๋‹์ด ํ”„๋กœ์ ํŠธ ํด๋” ์•ˆ์— ์žˆ๋Š”๊ฑด๊ฐ€์š”?

์ผ๋‹จ ํ”„๋กœ๋น„์ €๋‹์€ ํ”„๋กœ์ ํŠธ ํด๋” ์™ธ๋ถ€์— ์žˆ์–ด๋„ ๋“ฑ๋ก๊ฐ€๋Šฅํ•˜๊ธฐ์— ํด๋”์— ๋„ฃ๋Š”๊ฒƒ๋ณด๋‹ค ์™ธ๋ถ€์— ๋‘๋Š”๊ฒƒ์„ ๊ถŒ์žฅ๋“œ๋ฆฝ๋‹ˆ๋‹ค!

์•„๋งˆ ์กฐ๋งŒ๊ฐ„ ๋ชจ๋“ˆํ™” ๋“ค์–ด๊ฐ€๋ฉด ๊นŒ๋จน์œผ์…จ๋‹ค๊ฐ€ ๋˜ ํ”„๋กœ๋น„์ €๋‹ ๋“ค์–ด๊ฐ€์‹ญ๋‹ˆ๋‹ค ๐Ÿฅฒ

์™ธ๋ถ€์— ๋‘์…จ๋‹ค๋ฉด ignore ์„ธํŒ… ์ง€์›Œ์ฃผ์‹œ๊ธฐ๊นŒ์ง€ ํ•˜๋ฉด ๊ฐ์‚ฌํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค ๐Ÿ™‡๐Ÿปโ€โ™‚๏ธ

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ธŒ๋žœ์น˜ ๋ถ„๋ฆฌ ์ดํ›„ ์— ์ž‘์—…ํ•ด๋‘”๊ฑฐ๊ตฐ๋‡จ.. ์™ธ๋ถ€์— ๋‘๋„๋ก ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค ๐Ÿ˜‚

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zzangzzangguy ์ด๋ฒˆ PR์—์„œ ์ œ๊ฑฐํ•ด์ฃผ์„ธ์š”!

์ด๋ฒˆ PR์— ๋“ค์–ด๊ฐ€๋ฒ„๋ฆฌ๋ฉด ๋‚˜์ค‘์— ๊นŒ๋จน๊ณ  ๋‚จ์•„์žˆ์„๊ฒƒ ๊ฐ™์•„์„œ๐Ÿฅฒ

1 change: 1 addition & 0 deletions Poppool/File.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ฌด์Šจ ํŒŒ์ผ์ด์ฃ ?

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- unused_declaration
4 changes: 4 additions & 0 deletions Poppool/Poppool.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,7 @@
4EE360FD2D91876300D2441D /* NMapsMap in Frameworks */ = {isa = PBXBuildFile; productRef = 4EE360FC2D91876300D2441D /* NMapsMap */; };
4EE5A3D32D40E4A600A2469A /* MapGuideReactor.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4EE5A3D22D40E4A600A2469A /* MapGuideReactor.swift */; };
4EEA13072DA7CDDA00775256 /* PopUpImagesCollectionView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4EEA13062DA7CDDA00775256 /* PopUpImagesCollectionView.swift */; };
4EEA13142DABB0D900775256 /* MapViewController+Handlers.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4EEA13132DABB0D900775256 /* MapViewController+Handlers.swift */; };
4EEA1D8F2D352012003E7DE9 /* ImageCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4EEA1D8E2D352012003E7DE9 /* ImageCell.swift */; };
4EEA1D912D352027003E7DE9 /* ExtendedImage.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4EEA1D902D352027003E7DE9 /* ExtendedImage.swift */; };
4EECA3942D56770B00A07CCA /* MapPopUpStore.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4E685EBB2D12CEB6001EF91C /* MapPopUpStore.swift */; };
Expand Down Expand Up @@ -892,6 +893,7 @@
4EDE57022D5E70650014D924 /* LocationPermissionBottomSheet.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = LocationPermissionBottomSheet.swift; sourceTree = "<group>"; };
4EE5A3D22D40E4A600A2469A /* MapGuideReactor.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MapGuideReactor.swift; sourceTree = "<group>"; };
4EEA13062DA7CDDA00775256 /* PopUpImagesCollectionView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PopUpImagesCollectionView.swift; sourceTree = "<group>"; };
4EEA13132DABB0D900775256 /* MapViewController+Handlers.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "MapViewController+Handlers.swift"; sourceTree = "<group>"; };
4EEA1D8E2D352012003E7DE9 /* ImageCell.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ImageCell.swift; sourceTree = "<group>"; };
4EEA1D902D352027003E7DE9 /* ExtendedImage.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ExtendedImage.swift; sourceTree = "<group>"; };
4EED9BAB2D22730400B288E7 /* FilterType.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FilterType.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -2766,6 +2768,7 @@
4E685EC92D12CEB6001EF91C /* MapSearchInput.swift */,
4E685ECB2D12CEB6001EF91C /* MapView.swift */,
4E685ECC2D12CEB6001EF91C /* MapViewController.swift */,
4EEA13132DABB0D900775256 /* MapViewController+Handlers.swift */,
);
path = MapView;
sourceTree = "<group>";
Expand Down Expand Up @@ -3429,6 +3432,7 @@
088DE2582D144B0F0030FA9E /* DetailCommentProfileView.swift in Sources */,
0818989E2D2BAA610067BF01 /* WithdrawlCheckModalController.swift in Sources */,
081898902D295DC80067BF01 /* MyPageLogoutSectionCell.swift in Sources */,
4EEA13142DABB0D900775256 /* MapViewController+Handlers.swift in Sources */,
081898EE2D33A39D0067BF01 /* MyCommentSortedModalController.swift in Sources */,
081898AA2D2CEA2F0067BF01 /* WithdrawlCheckSectionCell.swift in Sources */,
086DD8CC2CFDFEA800B97D3B /* HomeListController.swift in Sources */,
Expand Down
2 changes: 1 addition & 1 deletion Poppool/Poppool/Domain/UseCase/MapUseCase.swift
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class DefaultMapUseCase: MapUseCase {
northEastLon: northEastLon,
southWestLat: southWestLat,
southWestLon: southWestLon,
categories: categories // โ† ๊ทธ๋Œ€๋กœ ๋„˜๊ธด๋‹ค
categories: categories
)
.map { $0.map { $0.toDomain() } }
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,6 @@ final class AdminBottomSheetView: UIView {

// MARK: - Public Methods
func updateContentVisibility(isCategorySelected: Bool) {
Logger.log(message: "๋†’์ด ๋ณ€๊ฒฝ ์‹œ์ž‘: \(isCategorySelected ? "์นดํ…Œ๊ณ ๋ฆฌ" : "์ƒํƒœ๊ฐ’")", category: .debug)

let newHeight: CGFloat = isCategorySelected ? 200 : 160

Expand All @@ -220,6 +219,5 @@ final class AdminBottomSheetView: UIView {
setNeedsLayout()
layoutIfNeeded()

Logger.log(message: "๋†’์ด ๋ณ€๊ฒฝ ์™„๋ฃŒ", category: .debug)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -283,12 +283,10 @@ extension PopUpStoreRegisterViewController {
}

private func showLoadingIndicator() {
// ๋กœ๋”ฉ ์ธ๋””์ผ€์ดํ„ฐ ํ‘œ์‹œ ๋กœ์ง ๊ตฌํ˜„
// ์˜ˆ: Activity Indicator ๋˜๋Š” ์ปค์Šคํ…€ ๋กœ๋”ฉ ๋ทฐ ํ‘œ์‹œ

}

private func hideLoadingIndicator() {
// ๋กœ๋”ฉ ์ธ๋””์ผ€์ดํ„ฐ ์ˆจ๊น€ ๋กœ์ง ๊ตฌํ˜„
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๋ ‡๊ฒŒ ๋˜๋ฉด ๋น„์–ด์žˆ๋Š” ๋ฉ”์„œ๋“œ์ธ๋ฐ ์ง€์šฐ์‹œ๋Š”๊ฑด ์–ด๋–จ๊นŒ์š”?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ ˆ๊ฑฐ์‹œ์ฝ”๋“œ.. ใ…œ ์ œ๊ฑฐํ•˜๋„๋ก ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค


private func showSuccessAlert(isUpdate: Bool) {
Expand Down Expand Up @@ -322,7 +320,6 @@ extension PopUpStoreRegisterViewController: View {

func bind(reactor: Reactor) {
// MARK: - Input (View -> Reactor)
// ํ…์ŠคํŠธ ํ•„๋“œ ๋ฐ”์ธ๋”ฉ
self.mainView.nameField.rx.text.orEmpty
.distinctUntilChanged()
.map { Reactor.Action.updateName($0) }
Expand Down
5 changes: 2 additions & 3 deletions Poppool/Poppool/Presentation/Scene/Admin/AdminStoreCell.swift
Original file line number Diff line number Diff line change
Expand Up @@ -76,15 +76,14 @@ final class AdminStoreCell: UITableViewCell {

// MARK: - Configure
func configure(with store: GetAdminPopUpStoreListResponseDTO.PopUpStore) {
Logger.log(message: "์…€ ๋ฐ์ดํ„ฐ ๋ฐ”์ธ๋”ฉ: \(store)", category: .debug)
// Logger.log(message: "์…€ ๋ฐ์ดํ„ฐ ๋ฐ”์ธ๋”ฉ: \(store)", category: .debug)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์‚ฌ์šฉํ•˜์ง€ ์•Š๋Š”๋‹ค๋ฉด ์ง€์šฐ์‹œ๋Š”๊ฒƒ ์ถ”์ฒœ๋“œ๋ฆฝ๋‹ˆ๋‹ค!


titleLabel.text = store.name
categoryLabel.text = store.categoryName
statusChip.text = "์šด์˜"

// mainImageUrl์—์„œ baseURL ๋ถ€๋ถ„ ์ œ๊ฑฐ
let imagePath = store.mainImageUrl.replacingOccurrences(of: KeyPath.popPoolS3BaseURL, with: "")
Logger.log(message: "์ด๋ฏธ์ง€ ๊ฒฝ๋กœ: \(imagePath)", category: .debug)
// Logger.log(message: "์ด๋ฏธ์ง€ ๊ฒฝ๋กœ: \(imagePath)", category: .debug)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์—ฌ๊ธฐ๋„

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ•ด๋‹นํ™”๋ฉด ๋””๋ฒ„๊น…์ค‘์— ์ž ๊น ์ฃผ์„์ฒ˜๋ฆฌํ•ด๋‘” ๋ถ€๋ถ„์ธ๋ฐ ํ•„์š”์น˜์•Š์€๊ฒƒ ๊ฐ™์•„ ๋‹ค์Œ PR์— ์ œ๊ฑฐํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค

Copy link
Member

@0Hooni 0Hooni Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zzangzzangguy ์–ด์ฐจํ”ผ ์ง€๊ธˆ PR์ด ์ฃผ์„ ์ œ๊ฑฐ๋‹ˆ๊นŒ ๊ทธ๋ƒฅ ์—ฌ๊ธฐ์„œ ์ง€์›Œ๋„ ๋ ๊ฒƒ ๊ฐ™์•„์š”!

storeImageView.setPPImage(path: imagePath)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -350,15 +350,6 @@ final class MapReactor: Reactor {
updatedStores.insert(selectedStore, at: 0) // ๐Ÿ”ฅ ์„ ํƒ๋œ ๋งˆ์ปค๋ฅผ ์บ๋Ÿฌ์…€์˜ ์ฒซ ๋ฒˆ์งธ๋กœ ์„ค์ •
}

Logger.log(
message: """
Updated viewport stores:
- Total: \(updatedStores.count)
- Selected Store: \(state.selectedStore?.name ?? "None")
""",
category: .debug
)

newState.viewportStores = updatedStores

case let .setSelectedStore(store):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,11 @@ final class MapSearchInput: UIView, View {
}

func bind(reactor: MapReactor) {
// ํ…์ŠคํŠธํ•„๋“œ ์ž…๋ ฅ ๋กœ๊ทธ (ํ•„์š” ์‹œ ํ™•์ธ)
searchTextField.rx.text.orEmpty
.subscribe(onNext: { text in
print("[DEBUG] TextField Input: \(text)")
.subscribe(onNext: { _ in
})
.disposed(by: disposeBag)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ•ด๋‹น ์˜ต์ €๋ฒ„๋ฅผ ์‚ฌ์šฉํ•˜์ง€ ์•Š๋Š” ๊ฒƒ ๊ฐ™์€๋ฐ ์ง€์›Œ๋„ ๊ดœ์ฐฎ์ง€ ์•Š์„๊นŒ์š”.?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To DO๋กœ ๋ณ€๊ฒฝ๋˜์—ˆ์Šต๋‹ˆ๋‹ค!


// Reactor์˜ ์„ ํƒ๋œ ์œ„์น˜ ํ•„ํ„ฐ๋ฅผ ํ…์ŠคํŠธํ•„๋“œ์— ๋ฐ”์ธ๋”ฉ (์—†์œผ๋ฉด ๊ธฐ๋ณธ ๋ฌธ๊ตฌ)
reactor.state
.map { $0.selectedLocationFilters.first ?? "ํŒ์—…์Šคํ† ์–ด๋ช…์„ ์ž…๋ ฅํ•ด๋ณด์„ธ์š”" }
.distinctUntilChanged()
Expand All @@ -92,14 +89,12 @@ final class MapSearchInput: UIView, View {

// MARK: - Gesture Setup
private func setupGesture() {
// containerView์— ํƒญ ์ œ์Šค์ฒ˜๋ฅผ ์ถ”๊ฐ€ํ•˜์—ฌ ํ™”๋ฉด ์ „ํ™˜ ํŠธ๋ฆฌ๊ฑฐ
let tapGesture = UITapGestureRecognizer(target: self, action: #selector(handleTapGesture))
containerView.addGestureRecognizer(tapGesture)
containerView.isUserInteractionEnabled = true
}

@objc private func handleTapGesture() {
// onSearch ํด๋กœ์ €๋ฅผ ํ˜ธ์ถœํ•ด์„œ ํ™”๋ฉด ์ „ํ™˜์„ ์ง„ํ–‰
onSearch?(searchTextField.text ?? "")
}
}
Expand Down
Loading