-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor/#110 remove unused comments logger #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
ecbffa1
fadb4d7
5c0a2e4
1854d5e
293b3cc
ae89367
b1dba60
592540b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - unused_declaration |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -283,12 +283,10 @@ extension PopUpStoreRegisterViewController { | |
| } | ||
|
|
||
| private func showLoadingIndicator() { | ||
| // ๋ก๋ฉ ์ธ๋์ผ์ดํฐ ํ์ ๋ก์ง ๊ตฌํ | ||
| // ์: Activity Indicator ๋๋ ์ปค์คํ ๋ก๋ฉ ๋ทฐ ํ์ | ||
|
|
||
| } | ||
|
|
||
| private func hideLoadingIndicator() { | ||
| // ๋ก๋ฉ ์ธ๋์ผ์ดํฐ ์จ๊น ๋ก์ง ๊ตฌํ | ||
| } | ||
|
||
|
|
||
| private func showSuccessAlert(isUpdate: Bool) { | ||
|
|
@@ -322,7 +320,6 @@ extension PopUpStoreRegisterViewController: View { | |
|
|
||
| func bind(reactor: Reactor) { | ||
| // MARK: - Input (View -> Reactor) | ||
| // ํ ์คํธ ํ๋ ๋ฐ์ธ๋ฉ | ||
| self.mainView.nameField.rx.text.orEmpty | ||
| .distinctUntilChanged() | ||
| .map { Reactor.Action.updateName($0) } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -76,15 +76,14 @@ final class AdminStoreCell: UITableViewCell { | |
|
|
||
| // MARK: - Configure | ||
| func configure(with store: GetAdminPopUpStoreListResponseDTO.PopUpStore) { | ||
| Logger.log(message: "์ ๋ฐ์ดํฐ ๋ฐ์ธ๋ฉ: \(store)", category: .debug) | ||
| // Logger.log(message: "์ ๋ฐ์ดํฐ ๋ฐ์ธ๋ฉ: \(store)", category: .debug) | ||
|
||
|
|
||
| titleLabel.text = store.name | ||
| categoryLabel.text = store.categoryName | ||
| statusChip.text = "์ด์" | ||
|
|
||
| // mainImageUrl์์ baseURL ๋ถ๋ถ ์ ๊ฑฐ | ||
| let imagePath = store.mainImageUrl.replacingOccurrences(of: KeyPath.popPoolS3BaseURL, with: "") | ||
| Logger.log(message: "์ด๋ฏธ์ง ๊ฒฝ๋ก: \(imagePath)", category: .debug) | ||
| // Logger.log(message: "์ด๋ฏธ์ง ๊ฒฝ๋ก: \(imagePath)", category: .debug) | ||
|
||
| storeImageView.setPPImage(path: imagePath) | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -71,14 +71,11 @@ final class MapSearchInput: UIView, View { | |
| } | ||
|
|
||
| func bind(reactor: MapReactor) { | ||
| // ํ ์คํธํ๋ ์ ๋ ฅ ๋ก๊ทธ (ํ์ ์ ํ์ธ) | ||
| searchTextField.rx.text.orEmpty | ||
| .subscribe(onNext: { text in | ||
| print("[DEBUG] TextField Input: \(text)") | ||
| .subscribe(onNext: { _ in | ||
| }) | ||
| .disposed(by: disposeBag) | ||
|
||
|
|
||
| // Reactor์ ์ ํ๋ ์์น ํํฐ๋ฅผ ํ ์คํธํ๋์ ๋ฐ์ธ๋ฉ (์์ผ๋ฉด ๊ธฐ๋ณธ ๋ฌธ๊ตฌ) | ||
| reactor.state | ||
| .map { $0.selectedLocationFilters.first ?? "ํ์ ์คํ ์ด๋ช ์ ์ ๋ ฅํด๋ณด์ธ์" } | ||
| .distinctUntilChanged() | ||
|
|
@@ -92,14 +89,12 @@ final class MapSearchInput: UIView, View { | |
|
|
||
| // MARK: - Gesture Setup | ||
| private func setupGesture() { | ||
| // containerView์ ํญ ์ ์ค์ฒ๋ฅผ ์ถ๊ฐํ์ฌ ํ๋ฉด ์ ํ ํธ๋ฆฌ๊ฑฐ | ||
| let tapGesture = UITapGestureRecognizer(target: self, action: #selector(handleTapGesture)) | ||
| containerView.addGestureRecognizer(tapGesture) | ||
| containerView.isUserInteractionEnabled = true | ||
| } | ||
|
|
||
| @objc private func handleTapGesture() { | ||
| // onSearch ํด๋ก์ ๋ฅผ ํธ์ถํด์ ํ๋ฉด ์ ํ์ ์งํ | ||
| onSearch?(searchTextField.text ?? "") | ||
| } | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ํน์ ํ๋ก๋น์ ๋์ด ํ๋ก์ ํธ ํด๋ ์์ ์๋๊ฑด๊ฐ์?
์ผ๋จ ํ๋ก๋น์ ๋์ ํ๋ก์ ํธ ํด๋ ์ธ๋ถ์ ์์ด๋ ๋ฑ๋ก๊ฐ๋ฅํ๊ธฐ์ ํด๋์ ๋ฃ๋๊ฒ๋ณด๋ค ์ธ๋ถ์ ๋๋๊ฒ์ ๊ถ์ฅ๋๋ฆฝ๋๋ค!
์๋ง ์กฐ๋ง๊ฐ ๋ชจ๋ํ ๋ค์ด๊ฐ๋ฉด ๊น๋จน์ผ์ จ๋ค๊ฐ ๋ ํ๋ก๋น์ ๋ ๋ค์ด๊ฐ์ญ๋๋ค ๐ฅฒ
์ธ๋ถ์ ๋์ จ๋ค๋ฉด ignore ์ธํ ์ง์์ฃผ์๊ธฐ๊น์ง ํ๋ฉด ๊ฐ์ฌํ๊ฒ ์ต๋๋ค ๐๐ปโโ๏ธ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๋ธ๋์น ๋ถ๋ฆฌ ์ดํ ์ ์์ ํด๋๊ฑฐ๊ตฐ๋จ.. ์ธ๋ถ์ ๋๋๋ก ํ๊ฒ ์ต๋๋ค ๐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zzangzzangguy ์ด๋ฒ PR์์ ์ ๊ฑฐํด์ฃผ์ธ์!
์ด๋ฒ PR์ ๋ค์ด๊ฐ๋ฒ๋ฆฌ๋ฉด ๋์ค์ ๊น๋จน๊ณ ๋จ์์์๊ฒ ๊ฐ์์๐ฅฒ