Add new line before the content of each script file (fixes #126) #127
+341
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jaykul I run the unit test that I modified but expected the pipeline would run all tests, but it doesn't happen? EDIT: I run all tests locally and they pass. |
9 tasks
|
@Jaykul gentle reminder to see if you can get some time to review and merge this? |
|
There. I fixed the build ... in your PR ... so uhm. That's a thing now. |
|
Yes that is very convenient since it is default enabled on new PRs and opt-out for contributors. I use it often as a maintainer, but mostly to resolve conflicts. Even easier when you can tap Thanks for fixing the PR and merging it. Looking forward to a release (unless it already happened) 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will resolve issue #126 by adding a new line before the content of each script file.