recording: multiple fixes for better frame rate, padding, drawables #118
Conversation
| public var iconLeft: String? = null, | ||
| public var iconRight: String? = null, |
There was a problem hiding this comment.
they hold a base64 value similar to backgroundImage, if present in text fields, they hold a small icon at the start (before the text), or at the end.
There was a problem hiding this comment.
@pauldambra we don't have that, shall we add it?
Rate and review has no icon
There was a problem hiding this comment.
🤔 seems good to add to me... 👍
There was a problem hiding this comment.
Ah, I'm catching up here maybe... is it a custom library 🤔
I don't know how much we want to bake custom library stuff into the schema.
Willing to be led by you - I've no idea how popular this library is
There was a problem hiding this comment.
Shall we split things and get the padding fix in and then follow up with this icon change if we decide to do it?
There was a problem hiding this comment.
Its not a custom library, the icon is custom, but the drawables on the 4 possible positions are part of the UI design system as well.
https://developer.android.com/reference/android/widget/TextView#getCompoundDrawables()
There was a problem hiding this comment.
cool beans, I'll add this to schema/transformer 👍
will need to figure out what the defaults/rules are around display but that's just mechanical
| base64 = drawable.cloneAndToBase64(view) | ||
| // style.paddingTop = view.paddingTop.densityValue(displayMetrics.density) | ||
| // style.paddingBottom = view.paddingBottom.densityValue(displayMetrics.density) | ||
| // style.paddingLeft = view.paddingLeft.densityValue(displayMetrics.density) | ||
| // style.paddingRight = view.paddingRight.densityValue(displayMetrics.density) |
There was a problem hiding this comment.
need to keep the commented code?
There was a problem hiding this comment.
yes, but it is a TODO (have to figure out the offset), the padding fixes some cases and breaks others because of the drawable size (vectors), the OS adjusts to the right size but we don't have access to this info, so in some cases the padding will fix it, in some cases it will break it.
posthog-android/src/main/java/com/posthog/android/replay/PostHogReplayIntegration.kt
Show resolved
Hide resolved
marandaneto
changed the title
| @@ -31,6 +45,6 @@ internal class Debouncer( | |||
| } | |||
|
|
|||
| companion object { | |||
| private const val ONE_FRAME_MS = 64L | |||
| private const val DELAY_MS = 500L | |||
There was a problem hiding this comment.
I can almost see us letting someone configure this... not-blocking here just seeding the idea in your head :)
There was a problem hiding this comment.
yeah, I thought the same, lets see if this approach works better first, and happy to make it configurable otherwise.
| public var iconLeft: String? = null, | ||
| public var iconRight: String? = null, |
There was a problem hiding this comment.
cool beans, I'll add this to schema/transformer 👍
will need to figure out what the defaults/rules are around display but that's just mechanical
💡 Motivation and Context
💚 How did you test it?
📝 Checklist