-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Refactor GDPR stuff into a more readable consent class #1176
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: -4.41 kB (-0.45%) Total Size: 973 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
I messed around with the cypress tests for this a few months ago so I'm relatively confident that they cover this well (although I was focussed on replay consent)
Co-authored-by: Paul D'Ambra <[email protected]>
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Hey folks, I just wanted to raise awareness to the folks involved in this PR that I think it broke the SDK and has exposed users who were GDRP compliant, to being non-compliant with GDPR: #1547 |
Changes
The "GDPR" opt in/out code was reaaaaaallly messy. Been wanting to refactor it for a while but didn't have a strong need until recently (other PR where I was potentially modifying some bits).
ConsentManager
class to encapsulate the logicChecklist