chore: workspace migration (workflows) #1993

hpouillot · 2025-06-03T11:12:22Z

Migration PR: #1991

Requires sub-PR: #1995

Changes

Create setup action
Migrated workflows:
- bundled-size (fails because target branch needs to have the same workflows)
- es-check
- library-ci:
  - [x] unit test
  - [x] playwright
  - [x] functional test
  - [x] lint
- react
- testcafe
- minimum-version-ts-check

vercel · 2025-06-03T11:12:25Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
posthog-js	❌ Failed (Inspect)		Jun 6, 2025 1:13pm

github-actions · 2025-06-03T11:49:44Z

Download bundle size visualization

greptile-apps

PR Summary

This PR implements a monorepo workspace structure by creating a reusable setup action and migrating all workflows to use it, along with reorganizing ESLint configurations into package-specific files.

Created .github/actions/setup action to standardize Node.js setup, pnpm installation, and dependency caching across workflows
Migrated all workflow files to use packages/browser working directory, reflecting new workspace structure
Reorganized ESLint configurations by moving package-specific rules to their respective directories
Added eslint-rules as a workspace package with proper CommonJS configuration
Updated TypeScript version checks to run against multiple Node.js versions (18, 20, 22, 23) and TypeScript versions (4.7.2, 5.5.4, latest)

_{16 file(s) reviewed, 13 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

.github/actions/setup/action.yaml

.eslintrc.js

greptile-apps · 2025-06-04T06:58:37Z

.github/workflows/library-ci.yml

+      - run: pnpm tsc -b
+        working-directory: packages/browser


style: Consider adding --noEmit flag to tsc command since this is just for type checking

greptile-apps · 2025-06-04T06:59:22Z

packages/browser/.eslintrc.js

+            parserOptions: {
+                project: null,
+            },


logic: Setting project to null disables TypeScript type checking. Consider using a specific tsconfig for Playwright tests instead

is that true?
do we want to turn that off?

greptile-apps · 2025-06-04T06:59:23Z

packages/browser/.eslintrc.js

+            rules: {
+                'no-console': 'off',
+                '@typescript-eslint/no-require-imports': 'off',
+                'no-undef': 'off',


style: Disabling no-undef in playground could lead to runtime errors. Consider using a more specific override

packages/browser/react/.eslintrc.js

pnpm-workspace.yaml

pauldambra

same... hard to test but looks reasonable
i think a few greptile comments are correct-ish
but we can always resolve that at the top-level

# Ceci est le premier message de validation : fix linting # Ceci est le message de validation numéro 2 : update code owners # Ceci est le message de validation numéro 5 : update pnpm lockfile # Ceci est le message de validation numéro 6 : create setup action # Ceci est le message de validation numéro 7 : migrate bundled-size # Ceci est le message de validation numéro 8 : migrate escheck # Ceci est le message de validation numéro 9 : checkout before calling custom action # Ceci est le message de validation numéro 10 : migrate esbuild and bundled-size # Ceci est le message de validation numéro 11 : migrate library checks

fix testcafe

hpouillot force-pushed the workspace-migration branch from 9579d32 to 3d45324 Compare June 3, 2025 11:16

hpouillot force-pushed the workspace-migration-workflows branch from ea5b04f to f44d0e1 Compare June 3, 2025 11:17

vercel bot had a problem deploying to Preview June 3, 2025 11:17 Failure

hpouillot force-pushed the workspace-migration branch from 3d45324 to f8e63b3 Compare June 3, 2025 11:19

hpouillot force-pushed the workspace-migration-workflows branch from f44d0e1 to 1080910 Compare June 3, 2025 11:20

vercel bot had a problem deploying to Preview June 3, 2025 11:21 Failure

vercel bot had a problem deploying to Preview June 3, 2025 11:23 Failure

vercel bot had a problem deploying to Preview June 3, 2025 11:32 Failure

hpouillot force-pushed the workspace-migration-workflows branch from 3b77400 to 147c82f Compare June 3, 2025 11:45

vercel bot had a problem deploying to Preview June 3, 2025 11:46 Failure

hpouillot force-pushed the workspace-migration-workflows branch from 147c82f to 7ccef56 Compare June 3, 2025 12:07

vercel bot had a problem deploying to Preview June 3, 2025 12:08 Failure

vercel bot had a problem deploying to Preview June 3, 2025 12:23 Failure

hpouillot mentioned this pull request Jun 3, 2025

chore: workspace migration #1991

Merged

6 tasks

vercel bot had a problem deploying to Preview June 3, 2025 13:47 Failure

hpouillot force-pushed the workspace-migration-workflows branch from 39e830e to 0cbd534 Compare June 3, 2025 14:49

vercel bot had a problem deploying to Preview June 3, 2025 14:50 Failure

vercel bot had a problem deploying to Preview June 3, 2025 15:11 Failure

hpouillot force-pushed the workspace-migration branch from 7b88f86 to dbde4ae Compare June 3, 2025 16:27

hpouillot changed the title ~~chore: migrate workflows~~ chore: workspace migration (workflows) Jun 3, 2025

vercel bot had a problem deploying to Preview June 3, 2025 18:50 Failure

vercel bot had a problem deploying to Preview June 3, 2025 18:58 Failure

hpouillot force-pushed the workspace-migration-workflows branch from 553e041 to 975e3d2 Compare June 3, 2025 18:59

vercel bot had a problem deploying to Preview June 3, 2025 18:59 Failure

hpouillot force-pushed the workspace-migration-workflows branch from 975e3d2 to 474c6c8 Compare June 3, 2025 19:03

vercel bot had a problem deploying to Preview June 3, 2025 19:03 Failure

vercel bot had a problem deploying to Preview June 3, 2025 19:05 Failure

hpouillot marked this pull request as ready for review June 4, 2025 06:57

greptile-apps bot reviewed Jun 4, 2025

View reviewed changes

hpouillot mentioned this pull request Jun 4, 2025

chore: workspace migration (release) #1998

Merged

hpouillot force-pushed the workspace-migration branch from dbde4ae to cf8655d Compare June 4, 2025 13:53

hpouillot requested review from a team as code owners June 4, 2025 13:53

hpouillot requested review from pauldambra and veryayskiy and removed request for a team June 4, 2025 13:53

hpouillot force-pushed the workspace-migration-workflows branch from 76a63c5 to 704b8a3 Compare June 4, 2025 14:17

vercel bot had a problem deploying to Preview June 4, 2025 14:28 Failure

pauldambra approved these changes Jun 6, 2025

View reviewed changes

hpouillot force-pushed the workspace-migration branch from bf08543 to d20c05d Compare June 6, 2025 13:09

hpouillot added 3 commits June 6, 2025 15:13

fix ts version check workflow

dc5d99b

fix testcafe

update lockfile

6c0fdce

hpouillot force-pushed the workspace-migration-workflows branch from ffe2ac4 to 6c0fdce Compare June 6, 2025 13:13

vercel bot had a problem deploying to Preview June 6, 2025 13:13 Failure

hpouillot merged commit 9601d74 into workspace-migration Jun 6, 2025
18 of 25 checks passed

hpouillot deleted the workspace-migration-workflows branch June 6, 2025 13:22

hpouillot added a commit that referenced this pull request Jun 11, 2025

chore: workspace migration (workflows) (#1993)

dc337bb

hpouillot added a commit that referenced this pull request Jun 12, 2025

chore: workspace migration (workflows) (#1993)

0c6a6b8

hpouillot added a commit that referenced this pull request Jun 16, 2025

chore: workspace migration (workflows) (#1993)

8190875

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: workspace migration (workflows) #1993

chore: workspace migration (workflows) #1993

Uh oh!

hpouillot commented Jun 3, 2025 •

edited

Loading

Uh oh!

vercel bot commented Jun 3, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 3, 2025 •

edited

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot Jun 4, 2025

Uh oh!

greptile-apps bot Jun 4, 2025

Uh oh!

pauldambra Jun 6, 2025

Uh oh!

greptile-apps bot Jun 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pauldambra left a comment

Uh oh!

Uh oh!

Uh oh!

chore: workspace migration (workflows) #1993

chore: workspace migration (workflows) #1993

Uh oh!

Conversation

hpouillot commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

vercel bot commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

pauldambra Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pauldambra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hpouillot commented Jun 3, 2025 •

edited

Loading

vercel bot commented Jun 3, 2025 •

edited

Loading

github-actions bot commented Jun 3, 2025 •

edited

Loading