-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "context" #54
Remove "context" #54
Conversation
lol, was wondering about this today, I guess safe to remove, will do so 👌 |
I resolved the merge conflicts. I support this change, but I do have a concern that it might break existing customer code that calls client.capture("some_distinct_id", "some-event", None, None, datetime.now(tzutc()), None, None, True) When we remove the |
Deprecating might indeed be safer, as we don't want to break people doing a patch or minor update. It'll remain a no-op like now, but at least it'll be clear that it's not to be used. Then we can remove it altogether after a few months or so... |
I can make that change if you'd like. I'll see if I can find other examples for how we deprecate things. |
I opened a PR #182 to deprecate context. I'll close this PR and log an issue to remove context some time later. |
Issue created here: #183 |
We ignore it and never use it, so let's remove. This is a remnant from the early life of this library.