fix: loading utf-8 file when locale encoding is set to ascii#28
Merged
Conversation
steve-chavez
reviewed
Oct 8, 2025
steve-chavez
reviewed
Oct 8, 2025
| tests = | ||
| [ testCase "read-simple" $ readTest "simple.cfg" | ||
| , testCase "read-pathological" $ readTest "pathological.cfg" | ||
| , testCase "read-utf-8-with-ascii-locale" $ readTestWithLocale "utf-8.cfg" E.ascii |
Member
There was a problem hiding this comment.
Q: Prior to the change, did this one fail with:
hGetContents: invalid argument (cannot decode byte sequence starting from ..
Same as PostgREST/postgrest#4379 (comment)?
Member
Author
There was a problem hiding this comment.
Yes, exactly! If I remove this change and re-run tests, I get:
read-utf-8-with-ascii-locale: [Failed]
ERROR: tests/resources/utf-8.cfg: hGetContents: invalid argument (cannot decode byte sequence starting from 195)
EDIT: A couple other tests slightly change in output, so I modified accordingly.
Configurator-pg fails to load UTF-8 encoded files when the locale settings are set to ASCII chars. This commit fixes this by using a safer and faster UTF-8 decoding when reading files. See: PostgREST/postgrest#4386 (comment) for more info on this. Signed-off-by: Taimoor Zaeem <taimoorzaeem@gmail.com>
taimoorzaeem
force-pushed
the
fix/load-utf-8
branch
from
8cac77f to
0a9f4c5
Compare
Member
|
@laurenceisla I saw you did a release previously, could you make a new release for this fix? 🙏 |
Member
Yup, will do. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurator-pg fails to load UTF-8 encoded files when the locale settings are set to ASCII chars. This commit fixes this by using a safer and faster UTF-8 decoding when reading files.
See: PostgREST/postgrest#4386 (comment) for more info on this.