Skip to content

fix: log 503 client error to stderr #3896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

taimoorzaeem
Copy link
Collaborator

@taimoorzaeem taimoorzaeem commented Feb 3, 2025

Closes #3841.

Should this go under feat? Maybe we should introduce new commit prefix for logging like maybe log: ...?

@wolfgangwalther
Copy link
Member

Should this go under fix or feat?

The point of "fix or feat" is to easily decide which version to bump and/or whether to backpatch...

Maybe we should introduce new commit prefix for logging like maybe log: ...?

... where log: would not answer any of those questions.

Since there is nothing really broken, I wouldn't bother with backpatching. For me, this is an "improvement of an existing feature", not a fix. So feat:.

@steve-chavez
Copy link
Member

Since there is nothing really broken, I wouldn't bother with backpatching

The crit level would be kinda broken as mentioned in #3841 (comment). So this should be a fix:...

@taimoorzaeem taimoorzaeem changed the title feat: log 503 client error to stderr fix: log 503 client error to stderr Feb 5, 2025
@steve-chavez steve-chavez merged commit c96dc3e into PostgREST:main Feb 9, 2025
22 checks passed
@taimoorzaeem taimoorzaeem deleted the issue3841/log-503 branch February 9, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

PostgREST does not log 503 errors to stderr
4 participants