Skip to content

fix: loading utf-8 config files with ascii locale set#4398

Merged
steve-chavez merged 1 commit into
PostgREST:mainfrom
taimoorzaeem:chore/update-configurator-pg
Oct 14, 2025
Merged

fix: loading utf-8 config files with ascii locale set#4398
steve-chavez merged 1 commit into
PostgREST:mainfrom
taimoorzaeem:chore/update-configurator-pg

Conversation

@taimoorzaeem

@taimoorzaeem taimoorzaeem commented Oct 13, 2025

Copy link
Copy Markdown
Member

Updates configurator-pg to version 0.2.11. This resolves #4386.

@wolfgangwalther

Copy link
Copy Markdown
Member

You should update the constraints in postgrest.cabal to make sure this is always build with that new version.

@taimoorzaeem taimoorzaeem force-pushed the chore/update-configurator-pg branch from 1ecc634 to d6c5657 Compare October 13, 2025 13:39
@taimoorzaeem taimoorzaeem marked this pull request as draft October 13, 2025 13:50
@taimoorzaeem taimoorzaeem marked this pull request as ready for review October 13, 2025 14:01
@taimoorzaeem taimoorzaeem force-pushed the chore/update-configurator-pg branch from eafccc1 to 9a762ad Compare October 14, 2025 05:27
@wolfgangwalther

Copy link
Copy Markdown
Member

Let's add a changelog entry for #4386 and squash all commits in here to a fix: ....

Updates configurator-pg to version 0.2.11. This resolves PostgREST#4386.

Signed-off-by: Taimoor Zaeem <taimoorzaeem@gmail.com>
@taimoorzaeem taimoorzaeem force-pushed the chore/update-configurator-pg branch from 9a762ad to 2c5e75c Compare October 14, 2025 13:00
@taimoorzaeem taimoorzaeem changed the title Update configurator-pg version to 0.2.11 fix: loading utf-8 config files with ascii locale set Oct 14, 2025

@wolfgangwalther wolfgangwalther left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@steve-chavez steve-chavez merged commit 07681d1 into PostgREST:main Oct 14, 2025
35 checks passed
@taimoorzaeem taimoorzaeem deleted the chore/update-configurator-pg branch October 14, 2025 15:28
@taimoorzaeem

Copy link
Copy Markdown
Member Author

@wolfgangwalther Please don't backport this fix yet. 🙏

@postgrest-ci

postgrest-ci Bot commented Oct 23, 2025

Copy link
Copy Markdown

Backport failed for v13, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin v13
git worktree add -d .worktree/backport-4398-to-v13 origin/v13
cd .worktree/backport-4398-to-v13
git switch --create backport-4398-to-v13
git cherry-pick -x 07681d1b5b9150f21329962980b3423a91bfa5cf

@wolfgangwalther

Copy link
Copy Markdown
Member

Are you going to create the backport, @taimoorzaeem?

@taimoorzaeem

Copy link
Copy Markdown
Member Author

Are you going to create the backport, @taimoorzaeem?

Yes sure. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Loading utf8 config files with different locale set

3 participants