chore: run doctests in parallel#5094
Merged
wolfgangwalther merged 2 commits intoJul 14, 2026
Merged
Conversation
This essentially just tests upstream's show instance.
wolfgangwalther
commented
Jul 12, 2026
Runs the doctests much faster, which is potentially useful in combination with postgrest-watch for local development. This implies that doctests run on compiled code, not in a GHCi session, which has some implications: - Only exported functions can be tested. - Imports need to be made explicit in doctests themselves. On the flipside, this would allow us to potentially include doctest results in code coverage, I believe. This change is a requirement to vendor hasql, which otherwise breaks the existing doctests: hasql contains a .hsc file, which *needs* to be compiled - not interpreted - to make the tests work.
920cdcc to
6a3e60e
Compare
taimoorzaeem
approved these changes
Jul 13, 2026
steve-chavez
approved these changes
Jul 13, 2026
steve-chavez
left a comment
Member
There was a problem hiding this comment.
On the flipside, this would allow us to potentially include doctest results in code coverage, I believe.
Sounds great! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs the doctests much faster, which is potentially useful in combination with postgrest-watch for local development.
This implies that doctests run on compiled code, not in a GHCi session, which has some implications:
On the flipside, this would allow us to potentially include doctest results in code coverage, I believe.
This change is a requirement to vendor hasql, which otherwise breaks the existing doctests: hasql contains a .hsc file, which needs to be compiled - not interpreted - to make the tests work.