-
Notifications
You must be signed in to change notification settings - Fork 51
Mixed PowerShell example fix #1094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PSDesiredStateConfiguration v2.0.7 doesn't have this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from a small formatting change, this documentation looks good. I'm going to file a separate issue for updating the adapter to return a specific exit code for this failure state, but that's nonblocking for this PR.
a8ae081
to
f2b1319
Compare
…jsreyn/operation-methods into docs-known-issue-psmodulepath
@michaeltlombardi - actually after PR #1095 got merged, the issue becomes obsolete. I wasn't assuming we didn't want to specify a version for example when it gets solved. I have removed the whole block. Only the example fix remains. I'll update the title. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a test config and not intended to be an example, I can still approve this as it probably makes more sense to test with WinPS but if the intent is an example, ideally we'd have a more scenario complete example we put into configurations folder
PR Summary
This pull request adds a known issue when runningIt also fixes up an example, which was reported on the dsc channel (Discord).dsc resource list --adapter Microsoft.Windows/WindowsPowerShell
with the$env:PSModulePath
containing a ";" at the end.PR Context