CodeReview#2 of 11 from 4#105
Open
NicoloCervo wants to merge 183 commits intoPrandiniUniPD:codereviewfrom
Open
CodeReview#2 of 11 from 4#105NicoloCervo wants to merge 183 commits intoPrandiniUniPD:codereviewfrom
NicoloCervo wants to merge 183 commits intoPrandiniUniPD:codereviewfrom
Conversation
# Conflicts: # app/build.gradle # app/src/main/AndroidManifest.xml # app/src/main/java/unipd/se18/ocrcamera/ResultActivity.java # app/src/main/java/unipd/se18/ocrcamera/TextExtractor.java # app/src/main/res/layout/activity_result.xml # app/src/main/res/values/strings.xml
uploading google-services.json
Aggiunta ml-kit. problema: immagine storta
…-_merging_proposal_2+3_PP Workingbranch2 merging proposal 2+3 pp
implemented Weighted Levenshtein library
…er class to avoid multiple redundant reading/writing
TextExtractor inefficiency solution - performace improved
Changed at line 36 testCompile (deprecated) to testImplementation
Avoid null pointer exception in takePhoto method and after the text from OCR is extracted, in particular when the app tries to set it to the corresponing label on the UI.
Fixed Camera lag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code to review is the class AllergenManager (penultimo commit)