Codice esame leonardo rossi g2#138
Open
leopardo-rossi-developer wants to merge 3 commits intoPrandiniUniPD:codereviewfrom
Open
Codice esame leonardo rossi g2#138leopardo-rossi-developer wants to merge 3 commits intoPrandiniUniPD:codereviewfrom
leopardo-rossi-developer wants to merge 3 commits intoPrandiniUniPD:codereviewfrom
Conversation
The method's for the code review are: takePhoto() and tempFileImage().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Questo è il codice da me sviluppato durante tutto il corso con l'aggiunta della checklist delle cose per me importanti da controllare durante una code review.
Tra tutte le classi caricate ShowPost_VM e PostDetail_VM, sono quelle che più preferisco in quanto sfruttano l'architettura MVVM (Model-View-ViewModel) e utilizzano un po' tutte le conoscenze e competenze pregresse ed acquisite durante il corso.
Inoltre della classe CameraActivity è da considerare solo il metodo tempFileImage()