Exam Code 22/02/19 - Pietro Balzan (mat. 1139703)#148
Open
BalzPit wants to merge 1 commit intoPrandiniUniPD:codereviewfrom
Open
Exam Code 22/02/19 - Pietro Balzan (mat. 1139703)#148BalzPit wants to merge 1 commit intoPrandiniUniPD:codereviewfrom
BalzPit wants to merge 1 commit intoPrandiniUniPD:codereviewfrom
Conversation
Here i put 6 classes to review. Brightness recognition is used in ResultActivity to determine under/over exposure. AllergensListAdapter, AllergensSearchFragment, UserAllergensFragment and MainAllergensActivity let the user select a personal list of allergens that are looked for in the list of recognized ingredients in ResultActivity. BaseActivity is used to improve (decrease) code redundancy for the implementation of a bottomBarMenu that lets the user switch between activities: in the previous iterations (that i will not post here, there also was a version of an hamburgermenu that did the same thing as the bottombarmenu), every activity had to re-define a bottombar and all the cases for each button in the menu. Now an activity that should have a bottombarmenu only has to extend BaseActivity and implement two of its methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear professor
Here is what i think is the best code I wrote during this semester. It mainly affects the Front-end implementation of activities and UI elements, with a focus on user experience and the "usability" of the app.
Brightness recognition is used in ResultActivity to determine under/over exposure of the taken picture.
AllergensListAdapter, AllergensSearchFragment, UserAllergensFragment and MainAllergensActivity let the user select a personal list of allergens that are looked for in the list of recognized ingredients in ResultActivity.
BaseActivity is new for this latest sprint and is used to improve (decrease) code redundancy for the implementation of a bottomBarMenu that lets the user switch between activities: in the previous iterations of this menu, that i will not post here, (there was also a version of this functionality of switching between activities made with an "hamburger menu" (side scrolling revealed the menu)), every activity had to re-define a bottombar and all the cases for each button in the menu. Now all activities that have a bottombarmenu only have to extend BaseActivity and implement two of its methods.
I'd like to use this opportunity to thank my group's members that lent me a hand in various circumstances, with the special mention of @frankplus , who helped the most by a long margin.
The checklist I used for my code reviews were mainly the java Style Guide document that (if i remember correctly) group 4 made and the index of 'Effective java' by Joshua Bloch.