Exam code 22/02/19 - Thomas Porro (mat. 1140680)#150
Open
thomasporro wants to merge 24 commits intoPrandiniUniPD:CommonDemofrom
Open
Exam code 22/02/19 - Thomas Porro (mat. 1140680)#150thomasporro wants to merge 24 commits intoPrandiniUniPD:CommonDemofrom
thomasporro wants to merge 24 commits intoPrandiniUniPD:CommonDemofrom
Conversation
For review
See if now the code looks better
I think I fixed all the issues you pointed out, could you check how is it now?
Added the suffix parameter in the _save_ method
Merge from review's changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salve professore,
durante questi mesi mi sono impegnato nella scrittura del modulo dell'image processing. Purtroppo io e miei compagni durante le settimane ci siamo resi conto in questo ambito per avere un piccolo miglioramento bisogna impiegare davvero molto tempo, quindi la quantità di codice scritto è relativamente ridotta ed abbiamo cercato di curarla al massimo delle nostre capacità sebbene siano ancora molto limitate. Le classi di cui vado più fiero sono ExtractTheText.java e PreProcessing.java. Ho caricato anche il resto del modulo a cui ho preso parte perché penso sia importante per capire alcuni parti del codice.
Detto questo il corso è stato veramente educativo ed impegnativo e sono contento di avervi potuto partecipare