Repository navigation
remove(base_exchange): remove base exchange implementation - #24
Merged
Merged
Conversation
Praying
commented
Jan 4, 2026
Praying
commented
Owner
- Removed BaseExchange struct and all associated functionality including market data caching, API configuration management, common request/response handling, authentication and signing, and rate limiting
- Removed ExchangeConfig and ExchangeConfigBuilder with all configuration options including API credentials, timeouts, retry policies, and proxy settings
- Removed MarketCache struct with market and currency data storage and indexing
- Removed all parsing methods for ticker, trade, order, balance, and order book data
- Removed fee calculation and precision conversion methods
- Removed throttle method and nonce generation functionality
- Removed URL query building and JSON parsing utilities
- Removed HTTP error handling and safe value extraction methods
- Removed BaseExchange struct and all associated functionality including market data caching, API configuration management, common request/response handling, authentication and signing, and rate limiting - Removed ExchangeConfig and ExchangeConfigBuilder with all configuration options including API credentials, timeouts, retry policies, and proxy settings - Removed MarketCache struct with market and currency data storage and indexing - Removed all parsing methods for ticker, trade, order, balance, and order book data - Removed fee calculation and precision conversion methods - Removed throttle method and nonce generation functionality - Removed URL query building and JSON parsing utilities - Removed HTTP error handling and safe value extraction methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.