-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lechat): Add new presence #9271
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
presenceState = strings.readingResponse | ||
} | ||
else { | ||
presenceState = null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
null
is not assignable to string type variable
presenceDetail = showTitle | ||
? document.querySelector('a[aria-label="Open chat"]>div').textContent | ||
: strings.talkingWithAi | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✖ pmd /home/runner/work/Presences/Presences/websites/L/Le Chat/presence.ts (32,5): Type 'string | null' is not assignable to type 'string'.
Type 'null' is not assignable to type 'string'.
✖ pmd /home/runner/work/Presences/Presences/websites/L/Le Chat/presence.ts (33,9): Object is possibly 'null'.
} | ||
|
||
// Checking if the user is currently typing a question | ||
if (document.querySelector('textarea').textContent !== '') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pmd /home/runner/work/Presences/Presences/websites/L/Le Chat/presence.ts (41,7): Object is possibly 'null'.
presenceDetail = strings.newPrompt | ||
} | ||
else if (pathname.includes('/chat/')) { | ||
presenceDetail = showTitle |
Check failure
Code scanning / PMD
Makes sure the TypeScript files are correct Error
Type 'null' is not assignable to type 'string'.
} | ||
else if (pathname.includes('/chat/')) { | ||
presenceDetail = showTitle | ||
? document.querySelector('a[aria-label="Open chat"]>div').textContent |
Check failure
Code scanning / PMD
Makes sure the TypeScript files are correct Error
} | ||
|
||
// Checking if the user is currently typing a question | ||
if (document.querySelector('textarea').textContent !== '') { |
Check failure
Code scanning / PMD
Makes sure the TypeScript files are correct Error
presenceState = strings.readingResponse | ||
} | ||
else { | ||
presenceState = null |
Check failure
Code scanning / PMD
Makes sure the TypeScript files are correct Error
Description
Added a new presence for the new Mistral AI Le Chat
Acknowledgements
yarn format
Screenshots
Proof showing the creation/modification is working as expected
Presence with chat title shown

Presence with chat title hidden
