Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lechat): Add new presence #9271

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

feat(lechat): Add new presence #9271

wants to merge 16 commits into from

Conversation

tschogge
Copy link
Contributor

Description

Added a new presence for the new Mistral AI Le Chat

Acknowledgements

Screenshots

Proof showing the creation/modification is working as expected

Presence with chat title shown
image

Presence with chat title hidden
image

@tschogge tschogge marked this pull request as ready for review February 11, 2025 14:08
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

presenceState = strings.readingResponse
}
else {
presenceState = null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null is not assignable to string type variable

Comment on lines +32 to +35
presenceDetail = showTitle
? document.querySelector('a[aria-label="Open chat"]>div').textContent
: strings.talkingWithAi
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✖ pmd /home/runner/work/Presences/Presences/websites/L/Le Chat/presence.ts (32,5): Type 'string | null' is not assignable to type 'string'.
Type 'null' is not assignable to type 'string'.
✖ pmd /home/runner/work/Presences/Presences/websites/L/Le Chat/presence.ts (33,9): Object is possibly 'null'.

}

// Checking if the user is currently typing a question
if (document.querySelector('textarea').textContent !== '') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pmd /home/runner/work/Presences/Presences/websites/L/Le Chat/presence.ts (41,7): Object is possibly 'null'.

presenceDetail = strings.newPrompt
}
else if (pathname.includes('/chat/')) {
presenceDetail = showTitle

Check failure

Code scanning / PMD

Makes sure the TypeScript files are correct Error

Type 'string | null' is not assignable to type 'string'.
Type 'null' is not assignable to type 'string'.
}
else if (pathname.includes('/chat/')) {
presenceDetail = showTitle
? document.querySelector('a[aria-label="Open chat"]>div').textContent

Check failure

Code scanning / PMD

Makes sure the TypeScript files are correct Error

Object is possibly 'null'.
}

// Checking if the user is currently typing a question
if (document.querySelector('textarea').textContent !== '') {

Check failure

Code scanning / PMD

Makes sure the TypeScript files are correct Error

Object is possibly 'null'.
presenceState = strings.readingResponse
}
else {
presenceState = null

Check failure

Code scanning / PMD

Makes sure the TypeScript files are correct Error

Type 'null' is not assignable to type 'string'.
"thumbnail": "https://i.imgur.com/GYS9A0f.png",
"color": "#fc7703",
"category": "other",
"tags": [

Check failure

Code scanning / PMD

Makes sure the `tags` don't contain the service name Error

Tags must not contain the service name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants