New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(AnimeciX): Add new presence #9272

Open

iSwesia wants to merge 18 commits into PreMiD:main from iSwesia:Swesia-AnimeciX

+220 −0

iSwesia commented Feb 11, 2025

Description

Feature: Added Premid presences integration for the Animecix website.

Changes Made:

-Integrated Premid presences to fetch data from the Animecix website's page titles and content.
-Implemented dynamic updates to display the correct anime title and episode information as users watch.
-Provided real-time updates for current page content and the specific episodes being watched.

Additional Information:

-This change aims to enhance the user experience by providing more accurate and personalized information while watching anime.
-The Premid presences feature displays relevant title, episode name, and other related details based on the anime being watched.

Testing:

-Tested with several anime titles and episodes on the Animecix website. Presences are updated correctly.
-Each page has been tested one by one, no issues found.

Acknowledgements

I read the Presence Guidelines
I linted the code by running yarn format
The PR title follows the repo's commit conventions

Screenshots

Proof showing the creation/modification is working as expected


          Add files via upload

740313f

Signed-off-by: iSwesia <[email protected]>

github-advanced-security bot found potential problems

View reviewed changes

github-advanced-security bot left a comment

ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Kuriel23 reviewed

View reviewed changes

websites/A/AnimeciX/metadata.json Outdated

+              	},
+              	"url": "animecix.net",
+              	"version": "1.0.0",
+              	"logo": "https://discord.do/wp-content/uploads/2023/08/AnimeciX.jpg",

Contributor

Kuriel23 Feb 11, 2025

Logo should be 512x512. Use waifu2x if you need to upscale.

Kuriel23 reviewed

View reviewed changes

websites/A/AnimeciX/metadata.json Outdated

+              	"url": "animecix.net",
+              	"version": "1.0.0",
+              	"logo": "https://discord.do/wp-content/uploads/2023/08/AnimeciX.jpg",
+              	"thumbnail": "https://discord.do/wp-content/uploads/2023/08/AnimeciX.jpg",

Contributor

Kuriel23 Feb 11, 2025

Use a screenshot or a promotional image/banner.

Kuriel23 suggested changes

View reviewed changes

websites/A/AnimeciX/presence.ts Outdated

Comment on lines 3 to 5

		});

		const browsingTimestamp = Math.floor(Date.now() / 1000);

Contributor

Kuriel23 Feb 11, 2025

Suggested change

      
            });
          
            const browsingTimestamp = Math.floor(Date.now() / 1000);
          
            }),
          
            browsingTimestamp = Math.floor(Date.now() / 1000);

websites/A/AnimeciX/presence.ts Outdated

+              };
+              const updatePresence = () => {
+                  let presenceData: PresenceData = {

Contributor

Kuriel23 Feb 11, 2025

Suggested change

      
                let presenceData: PresenceData = {
          
                const presenceData: PresenceData = {

websites/A/AnimeciX/presence.ts Outdated

Comment on lines 13 to 17

+                  const observer = new MutationObserver(() => {
+                      callback();
+                  });
+                  observer.observe(document.body, { childList: true, subtree: true });

Contributor

Kuriel23 Feb 11, 2025

Suggested change

      
                const observer = new MutationObserver(() => {
          
                    callback();
          
                });
          
                observer.observe(document.body, { childList: true, subtree: true });
          
                new MutationObserver(() => {
          
                    callback();
          
                }).observe(document.body, { childList: true, subtree: true });

websites/A/AnimeciX/presence.ts Outdated

Comment on lines 33 to 41

+                      const episodeTitle = document.querySelectorAll(".t-title > .ng-star-inserted")[1]?.textContent;
+                      const SEInfo = document.querySelector(".episode-number")?.textContent;
+                      // Thumbnail
+                      // const animeImgElement = document.querySelector("img.media-image-el");
+                      const animeImg = document.querySelector<HTMLElement>("media-item-header")?.style.backgroundImage.match(/url\(["']?(.*?)["']?\)/)?.[1]
+                      presenceData.largeImageKey = animeImg;
+                      presenceData.details = episodeTitle || "Loading";
+                      presenceData.state = SEInfo || "Loading";

Contributor

Kuriel23 Feb 11, 2025

Suggested change

      
                    const episodeTitle = document.querySelectorAll(".t-title > .ng-star-inserted")[1]?.textContent;
          
                    const SEInfo = document.querySelector(".episode-number")?.textContent;
          
                    // Thumbnail
          
                    // const animeImgElement = document.querySelector("img.media-image-el");
          
                    const animeImg = document.querySelector<HTMLElement>("media-item-header")?.style.backgroundImage.match(/url\(["']?(.*?)["']?\)/)?.[1]
          
                    presenceData.largeImageKey = animeImg;
          
                    presenceData.details = episodeTitle || "Loading";
          
                    presenceData.state = SEInfo || "Loading";
          
                    presenceData.largeImageKey = document.querySelector<HTMLElement>("media-item-header")?.style.backgroundImage.match(/url\(["']?(.*?)["']?\)/)?.[1];
          
                    presenceData.details = document.querySelectorAll(".t-title > .ng-star-inserted")[1]?.textContent || "Loading";
          
                    presenceData.state = document.querySelector(".episode-number")?.textContent || "Loading";

websites/A/AnimeciX/presence.ts Outdated

Comment on lines 45 to 52

+                      const animeTitle = document.querySelector(".t-title a")?.textContent;
+                      // Thumbnail
+                      // const animeImgElement = document.querySelector("img.media-image-el");
+                      const animeImg = document.querySelector<HTMLElement>("media-item-header")?.style.backgroundImage.match(/url\(["']?(.*?)["']?\)/)?.[1]
+                      presenceData.largeImageKey = animeImg;
+                      presenceData.details = animeTitle || "Loading";
+                      presenceData.state = "Bölümler görüntüleniyor";

Contributor

Kuriel23 Feb 11, 2025

Suggested change

      
                    const animeTitle = document.querySelector(".t-title a")?.textContent;
          
                    // Thumbnail
          
                    // const animeImgElement = document.querySelector("img.media-image-el");
          
                    const animeImg = document.querySelector<HTMLElement>("media-item-header")?.style.backgroundImage.match(/url\(["']?(.*?)["']?\)/)?.[1]
          
                    presenceData.largeImageKey = animeImg;
          
                    presenceData.details = animeTitle || "Loading";
          
                    presenceData.state = "Bölümler görüntüleniyor";
          
                    presenceData.largeImageKey = document.querySelector<HTMLElement>("media-item-header")?.style.backgroundImage.match(/url\(["']?(.*?)["']?\)/)?.[1];
          
                    presenceData.details = document.querySelector(".t-title a")?.textContent || "Loading";
          
                    presenceData.state = "Bölümler görüntüleniyor";

websites/A/AnimeciX/presence.ts Outdated

Comment on lines 70 to 73

+                      const userImg = document.querySelector<HTMLImageElement>(".header > .user-avatar.real")?.src;
+                      const userName = document.querySelector(".header > h1.name")?.textContent;
+                      presenceData.largeImageKey = Assets.Logo;
+                      presenceData.smallImageKey = userImg;

Contributor

Kuriel23 Feb 11, 2025

Suggested change

      
                    const userImg = document.querySelector<HTMLImageElement>(".header > .user-avatar.real")?.src;
          
                    const userName = document.querySelector(".header > h1.name")?.textContent;
          
                    presenceData.largeImageKey = Assets.Logo;
          
                    presenceData.smallImageKey = userImg;
          
                    const userName = document.querySelector(".header > h1.name")?.textContent;
          
                    presenceData.largeImageKey = Assets.Logo;
          
                    presenceData.smallImageKey = document.querySelector<HTMLImageElement>(".header > .user-avatar.real")?.src;

websites/A/AnimeciX/presence.ts Outdated

+                      presenceData.smallImageText = userName;
+                      presenceData.details = "Kullanıcı görüntüleniyor:";
+                      presenceData.state = userName || "Loading..";
+                  } else if (document.location.pathname === "/watchlist") {

Contributor

Kuriel23 Feb 11, 2025

Prefer switch instead of else if...

switch (document.location) {
  case "watchlist": {
   // ... code
   break;
}
};

websites/A/AnimeciX/presence.ts Outdated

Comment on lines 121 to 126

+                      const keyword = document.querySelector(".query")?.textContent;
+                      presenceData.largeImageKey = Assets.Logo;
+                      presenceData.smallImageKey = Assets.Search;
+                      presenceData.smallImageText = "Aranıyor"
+                      presenceData.details = "Aranıyor:";
+                      presenceData.state = keyword;

Contributor

Kuriel23 Feb 11, 2025

Format with prettier to fix semicolons

Suggested change

      
                    const keyword = document.querySelector(".query")?.textContent;
          
                    presenceData.largeImageKey = Assets.Logo;
          
                    presenceData.smallImageKey = Assets.Search;
          
                    presenceData.smallImageText = "Aranıyor"
          
                    presenceData.details = "Aranıyor:";
          
                    presenceData.state = keyword;
          
                    presenceData.largeImageKey = Assets.Logo;
          
                    presenceData.smallImageKey = Assets.Search;
          
                    presenceData.smallImageText = "Aranıyor";
          
                    presenceData.details = "Aranıyor:";
          
                    presenceData.state = document.querySelector(".query")?.textContent;

websites/A/AnimeciX/presence.ts Show resolved Hide resolved

iSwesia added 8 commits

February 11, 2025 23:05


          Update metadata.json

44a3ff8

Signed-off-by: iSwesia <[email protected]>


          Update metadata.json

16af971

Signed-off-by: iSwesia <[email protected]>


          Update metadata.json

805b03b

Signed-off-by: iSwesia <[email protected]>


          Update metadata.json

1fbc6d2

Signed-off-by: iSwesia <[email protected]>


          Update presence.ts

826b5d3

Signed-off-by: iSwesia <[email protected]>


          Update presence.ts

3ac0a44

Signed-off-by: iSwesia <[email protected]>


          Update presence.ts

1b5a76a

Signed-off-by: iSwesia <[email protected]>


          Update metadata.json

b90a007

Signed-off-by: iSwesia <[email protected]>

theusaf added the activity creation label

theusaf and others added 7 commits

February 12, 2025 15:56


          Merge branch 'main' into Swesia-AnimeciX

452f1f1


          Update presence.ts

9abaa2d

Signed-off-by: iSwesia <[email protected]>


          Update metadata.json

6ff0939

Signed-off-by: iSwesia <[email protected]>


          Merge branch 'main' into Swesia-AnimeciX

f5fff4a


          Merge branch 'main' into Swesia-AnimeciX

9bb8ccc


          Merge branch 'main' into Swesia-AnimeciX

c813efc


          Merge branch 'main' into Swesia-AnimeciX

ef73af8

theusaf requested changes

View reviewed changes

websites/A/AnimeciX/presence.ts

+              enum Images {
+                Logo = 'https://i.imgur.com/ExLxNbB.png',
+                SettingsICO = 'https://i.imgur.com/pUucFeP.png',

Member

theusaf Feb 19, 2025

Asset should be 512x512px

websites/A/AnimeciX/presence.ts

+                  && document.location.pathname.includes('/episode/')
+                ) {
+                  // Thumbnail
+                  // const animeImgElement = document.querySelector("img.media-image-el");

Member

theusaf Feb 19, 2025

Suggested change

// const animeImgElement = document.querySelector("img.media-image-el");

websites/A/AnimeciX/presence.ts

+              function updatePresence() {
+                const presenceData: PresenceData = {
+                  largeImageKey: Images.Logo,
+                } as PresenceData

Member

theusaf Feb 19, 2025

Is the type cast needed here?

websites/A/AnimeciX/presence.ts

+                  && !document.location.pathname.includes('/episode/')
+                ) {
+                  // Thumbnail
+                  // const animeImgElement = document.querySelector("img.media-image-el");

Member

theusaf Feb 19, 2025

Suggested change

// const animeImgElement = document.querySelector("img.media-image-el");

websites/A/AnimeciX/presence.ts

Comment on lines +157 to +176

+                            break
+                          }
+                          case '/gw-rooms': {
+                            presenceData.largeImageKey = Images.Logo
+                            presenceData.smallImageKey = Assets.Premiere
+                            presenceData.smallImageText = 'Group Watch'
+                            presenceData.details = 'AnimeciX'
+                            presenceData.state = 'İzleme odaları görüntüleniyor..'
+                            break
+                          }
+                          case '/search': {
+                            presenceData.largeImageKey = Images.Logo
+                            presenceData.smallImageKey = Assets.Search
+                            presenceData.smallImageText = 'Aranıyor'
+                            presenceData.details = 'Aranıyor:'
+                            presenceData.state = document.querySelector('.query')?.textContent
+                            break
+                          }

Member

theusaf Feb 19, 2025

Remove extra newline between break and code


          Merge branch 'main' into Swesia-AnimeciX

f9325c0

github-advanced-security bot found potential problems

View reviewed changes

websites/A/AnimeciX/presence.ts

+              enum Images {
+                Logo = 'https://i.imgur.com/ExLxNbB.png',
+                SettingsICO = 'https://i.imgur.com/pUucFeP.png',

Check failure

Code scanning / PMD

Makes sure all images (logo and URLs) are exactly 512x512 pixels Error

Image URL dimensions must be exactly 512x512 pixels, got 500x500 for URL: https://i.imgur.com/pUucFeP.png


          Merge branch 'main' into Swesia-AnimeciX

4f61f71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

activity creation