New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(81Dojo): add activity #9277

Open

IcefoxKishi wants to merge 22 commits into PreMiD:main from IcefoxKishi:main

IcefoxKishi commented Feb 13, 2025

Description

Acknowledgements

[ x ] I read the Presence Guidelines
[ x ] I linted the code by running yarn format
[ x ] The PR title follows the repo's commit conventions

Screenshots

Proof showing the creation/modification is working as expected

![image](https://github.com/user-attachments/assets/3ad37d38-1a58-4cdb-a8f8-5fbab2ae98e8) ![image](https://github.com/user-attachments/assets/22ba9ce0-0439-4f4e-9971-0089a9f9592e) ![image](https://github.com/user-attachments/assets/afec00b5-baf3-41e1-badc-a20ec9970fa8)

IcefoxKishi added 5 commits

February 13, 2025 19:46


          upload

3e9f9db

Signed-off-by: Higitsune Fujiharu <[email protected]>


          massive expansion

0ea59d6

Signed-off-by: Higitsune Fujiharu <[email protected]>


          Delete websites/0-9/81Dojo/dist directory

e0f1867

Signed-off-by: Higitsune Fujiharu <[email protected]>


          Delete websites/0-9/81Dojo/tsconfig.json

35b7aee

Signed-off-by: Higitsune Fujiharu <[email protected]>


          lint (?)

eef03de

Signed-off-by: Higitsune Fujiharu <[email protected]>

github-advanced-security bot found potential problems

View reviewed changes

github-advanced-security bot left a comment

ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Contributor

Kuriel23 commented Feb 13, 2025

Use npm run lint:fix and fix the issues on VS Code.

Kuriel23 suggested changes

View reviewed changes

websites/0-9/81Dojo/presence.ts Outdated

+              const presence = new Presence({
+              	clientId: "1338891034310213683"
+              })
+              const enum Assets { // Other default assets can be found at index.d.ts

Contributor

Kuriel23 Feb 13, 2025

Suggested change

      
            const enum Assets { // Other default assets can be found at index.d.ts
          
            enum Assets {

websites/0-9/81Dojo/presence.ts Outdated Show resolved Hide resolved

websites/0-9/81Dojo/presence.ts Outdated Show resolved Hide resolved

websites/0-9/81Dojo/metadata.json Outdated Show resolved Hide resolved

IcefoxKishi added 5 commits

February 14, 2025 08:51


          image updates

46a7a7a

Signed-off-by: Higitsune Fujiharu <[email protected]>


          lint (TAKE TWO)

f05f133

Signed-off-by: Higitsune Fujiharu <[email protected]>


          assets update

4af659a

Signed-off-by: Higitsune Fujiharu <[email protected]>


          lint (again???)

0c86c14

Signed-off-by: Higitsune Fujiharu <[email protected]>


          json lint

5b36dfa

Signed-off-by: Higitsune Fujiharu <[email protected]>

theusaf added activity update activity creation and removed activity update labels

IcefoxKishi added 4 commits

February 14, 2025 13:14


          linting is hell

37f63ea

Signed-off-by: Higitsune Fujiharu <[email protected]>


          lintlintlint

c95875e

Signed-off-by: Higitsune Fujiharu <[email protected]>


          linting on

ed5cd59

Signed-off-by: Higitsune Fujiharu <[email protected]>


          lint.

256e0a0

Signed-off-by: Higitsune Fujiharu <[email protected]>

Author

IcefoxKishi commented Feb 14, 2025

Anyone mind telling me what Anthony's curly bracket conventions are (and what's up with the trailing comma requirements)? I've fixed up what I can understand.


          need i say more

83bc5f7

Signed-off-by: Higitsune Fujiharu <[email protected]>

github-advanced-security bot found potential problems

View reviewed changes

websites/0-9/81Dojo/presence.ts

Comment on lines +4 to +6

+              const enum Assets {
+                Logo = 'https://81dojo.com/images/81DojoLogo_Big.png',
+              }

Check failure

Code scanning / ESLint

Disallow specified syntax Error

Using 'TSEnumDeclaration[const=true]' is not allowed.

websites/0-9/81Dojo/presence.ts

+                switch (document.location.hostname) {
+                  case '81dojo.com':
+                    if (document.location.pathname === '/')
+                      presenceData.details = 'Viewing home page'

Check failure

Code scanning / ESLint

Enforce Anthony's style of curly bracket Error

Expect curly brackets

websites/0-9/81Dojo/presence.ts

+                    // todo: statuses for more pages
+                    else if (document.location.pathname.includes('/client/')) {
+                      if (Number.parseFloat(document.getElementById('layerLogin').style.zIndex) === 2)
+                        presenceData.details = 'Logging in to client'

Check failure

Code scanning / ESLint

Enforce Anthony's style of curly bracket Error

Expect curly brackets

websites/0-9/81Dojo/presence.ts

+                          presenceData.details = `In ${server} lobby`
+                        }
+                        else {
+                          const playerElements = document.querySelectorAll(

Check failure

Code scanning / ESLint

Enforce the consistent use of either backticks, double, or single quotes Error

Strings must use singlequote.

websites/0-9/81Dojo/presence.ts

Comment on lines +27 to +28

		const playerElements = document.querySelectorAll(
		"[id='player-info-name']"

Check failure

Code scanning / ESLint

Require or disallow trailing commas Error

Missing trailing comma.

websites/0-9/81Dojo/presence.ts

+                      }
+                    }
+                    else if (document.location.pathname.includes('/documents'))
+                      presenceData.details = `Reading the docs: ${document.getElementById('firstHeading').textContent}`

Check failure

Code scanning / ESLint

Enforce Anthony's style of curly bracket Error

Expect curly brackets

websites/0-9/81Dojo/presence.ts

Comment on lines +80 to +82

+                    if (document.location.pathname === '/'){
+                      presenceData.details = 'Viewing WebSystem'
+                    }

Check failure

Code scanning / ESLint

Enforce consistent spacing before blocks Error

Missing space before opening brace.

websites/0-9/81Dojo/presence.ts

+                      }
+                      else {
+                        presenceData.details = 'WebSystem: Browsing clubs'
+                      }

Check failure

Code scanning / ESLint

Enforce Anthony's style of curly bracket Error

Expect curly brackets

websites/0-9/81Dojo/presence.ts

Comment on lines +121 to +123

+                    else if (document.location.pathname.includes('/players/upload_avatar')){
+                      presenceData.details = 'WebSystem: Choosing avatar'
+                    }

Check failure

Code scanning / ESLint

Enforce consistent spacing before blocks Error

Missing space before opening brace.

websites/0-9/81Dojo/presence.ts

Comment on lines +124 to +126

+                    else if (document.location.pathname.includes('/players/favorites')){
+                      presenceData.details = 'WebSystem: Viewing favorited players'
+                    }

Check failure

Code scanning / ESLint

Enforce consistent spacing before blocks Error

Missing space before opening brace.


          ingame status fix

179d73e

Signed-off-by: Higitsune Fujiharu <[email protected]>

github-advanced-security bot found potential problems

View reviewed changes

websites/0-9/81Dojo/presence.ts Fixed Show fixed Hide fixed

IcefoxKishi and others added 2 commits

February 15, 2025 12:26


          fix (again)

1d4a31d

Signed-off-by: Higitsune Fujiharu <[email protected]>


          Merge branch 'main' into main

6a1fb1a

github-advanced-security bot found potential problems

View reviewed changes

websites/0-9/81Dojo/presence.ts

+                      presenceData.details = 'WebSystem: Viewing rankings'
+                    }
+                    else if (document.location.pathname.includes('/tournaments')) {
+                      if (Number.isInteger(Number.parseInt(document.location.pathname.substr(-1)))) {

Check failure

Code scanning / ESLint

Disallow using code marked as `@deprecated` Error

substr is deprecated. A legacy feature for browser compatibility

websites/0-9/81Dojo/presence.ts

+                      }
+                    }
+                    else if (document.location.pathname.includes('/titles')) {
+                      if (Number.isInteger(Number.parseInt(document.location.pathname.substr(-1)))) {

Check failure

Code scanning / ESLint

Disallow using code marked as `@deprecated` Error

substr is deprecated. A legacy feature for browser compatibility

websites/0-9/81Dojo/presence.ts

+                      }
+                    }
+                    else if (document.location.pathname.includes('/circles')) {
+                      if (Number.isInteger(Number.parseInt(document.location.pathname.substr(-1)))) {

Check failure

Code scanning / ESLint

Disallow using code marked as `@deprecated` Error

substr is deprecated. A legacy feature for browser compatibility


          Merge branch 'main' into main

3574ea8

github-advanced-security bot found potential problems

View reviewed changes

github-advanced-security bot left a comment

pmd found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Bas950 and others added 2 commits

February 20, 2025 14:44


          Merge branch 'main' into main

4c1361b


          expansion, innerhtml -> textcontent

1eae0f2

Signed-off-by: Higitsune Fujiharu <[email protected]>

github-advanced-security bot found potential problems

View reviewed changes

websites/0-9/81Dojo/presence.ts

Comment on lines +38 to +39

		.textContent.slice(3, 7)
		)

Check failure

Code scanning / ESLint

Require or disallow trailing commas Error

Missing trailing comma.

websites/0-9/81Dojo/presence.ts

+                      presenceData.details = 'WebSystem: Applying for certificate'
+                    }
+                    else if (document.location.pathname.includes('/kifu')) {
+                      presenceData.details = `WebSystem: Viewing kifu: ${document.getElementById("kifu_viewer").children.item(1).getElementsByTagName("b")[0]} vs. ${document.getElementById("kifu_viewer").children.item(1).getElementsByTagName("b")[1]}`

Check failure

Code scanning / ESLint

Enforce the consistent use of either backticks, double, or single quotes Error

Strings must use singlequote.

websites/0-9/81Dojo/presence.ts

+                      presenceData.details = 'WebSystem: Applying for certificate'
+                    }
+                    else if (document.location.pathname.includes('/kifu')) {
+                      presenceData.details = `WebSystem: Viewing kifu: ${document.getElementById("kifu_viewer").children.item(1).getElementsByTagName("b")[0]} vs. ${document.getElementById("kifu_viewer").children.item(1).getElementsByTagName("b")[1]}`

Check failure

Code scanning / ESLint

Enforce the consistent use of either backticks, double, or single quotes Error

Strings must use singlequote.

websites/0-9/81Dojo/presence.ts

+                      presenceData.details = 'WebSystem: Applying for certificate'
+                    }
+                    else if (document.location.pathname.includes('/kifu')) {
+                      presenceData.details = `WebSystem: Viewing kifu: ${document.getElementById("kifu_viewer").children.item(1).getElementsByTagName("b")[0]} vs. ${document.getElementById("kifu_viewer").children.item(1).getElementsByTagName("b")[1]}`

Check failure

Code scanning / ESLint

Enforce the consistent use of either backticks, double, or single quotes Error

Strings must use singlequote.

websites/0-9/81Dojo/presence.ts

+                      presenceData.details = 'WebSystem: Applying for certificate'
+                    }
+                    else if (document.location.pathname.includes('/kifu')) {
+                      presenceData.details = `WebSystem: Viewing kifu: ${document.getElementById("kifu_viewer").children.item(1).getElementsByTagName("b")[0]} vs. ${document.getElementById("kifu_viewer").children.item(1).getElementsByTagName("b")[1]}`

Check failure

Code scanning / ESLint

Enforce the consistent use of either backticks, double, or single quotes Error

Strings must use singlequote.

websites/0-9/81Dojo/presence.ts

+                      presenceData.details = `WebSystem: Viewing kifu: ${document.getElementById("kifu_viewer").children.item(1).getElementsByTagName("b")[0]} vs. ${document.getElementById("kifu_viewer").children.item(1).getElementsByTagName("b")[1]}`
+                    }
+                    else if (document.location.pathname.includes('/forums')) {
+                      if (document.getElementsByClassName("title") == null) {

Check failure

Code scanning / ESLint

Enforce the consistent use of either backticks, double, or single quotes Error

Strings must use singlequote.

websites/0-9/81Dojo/presence.ts

+                        presenceData.details = 'WebSystem: Viewing World Shogi Forum'
+                      }
+                      else {
+                        presenceData.details = `WebSystem: Viewing forum topic: ${document.getElementsByClassName("title")[0].textContent}`

Check failure

Code scanning / ESLint

Enforce the consistent use of either backticks, double, or single quotes Error

Strings must use singlequote.


          hotfix

fa6e9a4

Signed-off-by: Higitsune Fujiharu <[email protected]>

github-advanced-security bot found potential problems

View reviewed changes

websites/0-9/81Dojo/presence.ts

+                      }
+                    }
+                    else if (document.location.pathname.includes('/topics')) {
+                        presenceData.details = `WebSystem: Viewing forum topic: ${document.getElementsByClassName("title")[0].textContent}`

Check failure

Code scanning / ESLint

Enforce consistent indentation Error

Expected indentation of 8 spaces but found 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

activity creation