feat(Teckie): add Teckie support #9280
Conversation
websites/T/Teckie/metadata.json
Outdated
| "url": "teckie.nl", | ||
| "version": "1.0.0", | ||
| "logo": "https://i.imgur.com/Gagky0u.png", | ||
| "thumbnail": "https://i.imgur.com/fmINPqW.png", |
There was a problem hiding this comment.
Change to a wide screenshot or promotional image.
There was a problem hiding this comment.
how wide should it be then? like what aspect ratio?
There was a problem hiding this comment.
Try something 16:9 or 1280x720
There was a problem hiding this comment.
yeah im clueless at this point, check is also failing because ✖ pmd CDN_TOKEN environment variable is required. So not sure if it's to do with my thumbnail
There was a problem hiding this comment.
You can ignore that check for now, devs are working to resolve it
now a 560x560
There was a problem hiding this comment.
For English see below.
---------
Hallo Maatje,
Bedankt voor je PR. Ik heb wat opmerkingen/vragen hierover. Graag de verzochte wijzigingen maken.
Mocht je vragen hebben, stel ze in dit PR of op discord (@dark_ville)
Groet,
Mede Kaaskop
Dark
-----------
Hello Mate,
Thanks for your PR, i have some questions/notes about it. Please make the changes as requested.
If you have any questions feel free to ask in this pr or on discord (@dark_ville)
~Dark
| const presenceData: PresenceData = { | ||
| largeImageKey: ActivityAssets.Logo, | ||
| details: 'Bezoekt Teckie', | ||
| } |
There was a problem hiding this comment.
| } | |
| }, | |
| { pathname } = document.location; |
| let page = document.location.pathname.substring(7).replaceAll('-', ' ') | ||
| page = page.charAt(0).toUpperCase() + page.slice(1) | ||
| presenceData.details = 'Bekijkt een pagina' | ||
| presenceData.state = `Pagina: ${page}` |
There was a problem hiding this comment.
| let page = document.location.pathname.substring(7).replaceAll('-', ' ') | |
| page = page.charAt(0).toUpperCase() + page.slice(1) | |
| presenceData.details = 'Bekijkt een pagina' | |
| presenceData.state = `Pagina: ${page}` | |
| presenceData.details = 'Bekijkt een pagina' | |
| presenceData.state = `Pagina: ${document.title.split('– Teckie')?.[0]}` |
| let productTitle = document.getElementsByClassName('product__title')[0] | ||
| if (productTitle) { | ||
| productTitle = productTitle.getElementsByTagName('h1')[0] | ||
| if (productTitle) { | ||
| presenceData.state = `Product: ${productTitle.textContent}` | ||
| } | ||
| } |
There was a problem hiding this comment.
| let productTitle = document.getElementsByClassName('product__title')[0] | |
| if (productTitle) { | |
| productTitle = productTitle.getElementsByTagName('h1')[0] | |
| if (productTitle) { | |
| presenceData.state = `Product: ${productTitle.textContent}` | |
| } | |
| } | |
| presenceData.state = document.querySelector('.product__title')?.textContent?.trim()?.replace("\n ", "") ?? "" |
| let policyTitle = document.getElementsByClassName('shopify-policy__title')[0] | ||
| if (policyTitle) { | ||
| policyTitle = policyTitle.getElementsByTagName('h1')[0] | ||
| if (policyTitle) { | ||
| presenceData.state = `Policy: ${policyTitle.textContent}` | ||
| } | ||
| } |
There was a problem hiding this comment.
| let policyTitle = document.getElementsByClassName('shopify-policy__title')[0] | |
| if (policyTitle) { | |
| policyTitle = policyTitle.getElementsByTagName('h1')[0] | |
| if (policyTitle) { | |
| presenceData.state = `Policy: ${policyTitle.textContent}` | |
| } | |
| } | |
| presenceData.state = document.querySelector('.shopify-policy__title')?.textContent ?? "" |
| const blogTitle = document.getElementsByClassName('article-template__title')[0] | ||
| if (blogTitle) { | ||
| presenceData.state = `Blog: ${blogTitle.textContent}` | ||
| } |
There was a problem hiding this comment.
| const blogTitle = document.getElementsByClassName('article-template__title')[0] | |
| if (blogTitle) { | |
| presenceData.state = `Blog: ${blogTitle.textContent}` | |
| } | |
| presenceData.state = document.querySelector('[itemprop="headline"]')?.textContent.replace(/\n /gm, "") ?? "" |
|
Hello from mobile, I've been and still am sick with the flu. Will make changes once I'm better. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| }, | ||
| "url": "teckie.nl", | ||
| "version": "1.0.0", | ||
| "logo": "https://i.postimg.cc/FHdK56R2/my-ONfuy-waifu2x-art-noise1-scale-waifu2x-art-noise1-scale-waifu2x-art-noise1-scale.png", |
Check failure
Code scanning / PMD
Makes sure all images (logo and URLs) are exactly 512x512 pixels Error
| }) | ||
|
|
||
| enum ActivityAssets { // Other default assets can be found at index.d.ts | ||
| Logo = 'https://i.postimg.cc/FHdK56R2/my-ONfuy-waifu2x-art-noise1-scale-waifu2x-art-noise1-scale-waifu2x-art-noise1-scale.png', |
Check failure
Code scanning / PMD
Makes sure all images (logo and URLs) are exactly 512x512 pixels Error
Description
Add support for Teckie. A dutch computer sales, repair and support company. Has support for all pages. Checkout page just shows the status for the base url to protect privacy.
Sidenote: didn't run
yarn formatbut insteadnpm run lint:fix.yarn formatdidn't work for me and was told in the Discord server to usenpm run lint:fixinstead. Not sure if the PR template needs updating.Acknowledgements
yarn formatScreenshots
Proof showing the creation/modification is working as expected
Example 1:  Example 2:
