-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Framer): add activity #9282
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Amit <[email protected]>
Signed-off-by: Amit <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Signed-off-by: Amit <[email protected]>
Signed-off-by: Amit <[email protected]>
websites/F/Framer/metadata.json
Outdated
}, | ||
"url": "framer.com", | ||
"version": "1.0.12", | ||
"logo": "https://iili.io/2mZgC0P.jpg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logo should be 512x512px
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: Amit <[email protected]>
websites/F/Framer/metadata.json
Outdated
}, | ||
"url": "framer.com", | ||
"version": "1.0.12", | ||
"logo": "https://iili.io/2ydu31S.th.png", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image appears even smaller than the previous one. Also, ensure to update the logo URL in the code as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made the necessary changes to the code as per your request. The image URL title shows the image size as 500x500px, but its original size is 512x512px.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please upload the image to a host which retains the original 512x512px size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Image size is now 512x512px.
Signed-off-by: Amit <[email protected]>
Signed-off-by: Amit <[email protected]>
Signed-off-by: Amit <[email protected]>
Signed-off-by: Amit <[email protected]>
Co-authored-by: Daniel Lau <[email protected]> Signed-off-by: Amit <[email protected]>
Co-authored-by: Daniel Lau <[email protected]> Signed-off-by: Amit <[email protected]>
Description
This pull request adds support for Framer Presence, allowing users to display their activity on Framer in Discord via PreMiD.
Acknowledgements
yarn format
Screenshots
Proof showing the creation/modification is working as expected