Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Framer): add activity #9282

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat(Framer): add activity #9282

wants to merge 14 commits into from

Conversation

amit-thixd
Copy link

Description

This pull request adds support for Framer Presence, allowing users to display their activity on Framer in Discord via PreMiD.

Acknowledgements

Screenshots

Proof showing the creation/modification is working as expected

Screenshot 2025-02-14 130910

Screenshot 2025-02-14 130819

Screenshot 2025-02-14 131036

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@theusaf theusaf requested a review from Bas950 February 17, 2025 01:35
},
"url": "framer.com",
"version": "1.0.12",
"logo": "https://iili.io/2mZgC0P.jpg",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logo should be 512x512px

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@amit-thixd amit-thixd requested a review from theusaf February 17, 2025 05:19
},
"url": "framer.com",
"version": "1.0.12",
"logo": "https://iili.io/2ydu31S.th.png",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image appears even smaller than the previous one. Also, ensure to update the logo URL in the code as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the necessary changes to the code as per your request. The image URL title shows the image size as 500x500px, but its original size is 512x512px.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please upload the image to a host which retains the original 512x512px size

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Image size is now 512x512px.

amit-thixd and others added 2 commits February 20, 2025 10:41
Co-authored-by: Daniel Lau <[email protected]>
Signed-off-by: Amit <[email protected]>
Co-authored-by: Daniel Lau <[email protected]>
Signed-off-by: Amit <[email protected]>
@amit-thixd amit-thixd requested a review from theusaf February 20, 2025 05:19
@Bas950 Bas950 enabled auto-merge (squash) February 20, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants