Skip to content

Include task args in run_tasks_async independent case #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
superMDguy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Include task args in run_tasks_async independent case #1233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/marvin/fns/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,14 @@ async def run_tasks_async(
# If we have multiple independent tasks, run them concurrently
if len(tasks) > 1 and _tasks_are_independent(tasks):
# Run independent tasks concurrently using asyncio.gather
await asyncio.gather(*[task.run_async() for task in tasks])
await asyncio.gather(
*[
task.run_async(
thread=thread, raise_on_failure=raise_on_failure, handlers=handlers
)
Comment on lines +46 to +48
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task.run_async() method signature appears to be different from the one being called. Based on the context excerpt, task.run_async() doesn't accept thread, raise_on_failure, or handlers parameters, but this code is trying to pass them.

Suggested change
task.run_async(
thread=thread, raise_on_failure=raise_on_failure, handlers=handlers
)
task.run_async()

Copilot uses AI. Check for mistakes.
for task in tasks
]
)
return tasks
else:
# Use orchestrator for dependent tasks or single tasks
Expand Down