test(webhooks): add coverage for non-JSON string templates #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchnielsen
had a problem deploying
to
Acceptance Tests
GitHub Actions
Failure
mitchnielsen
force-pushed
the
webhook-templates
branch
from
c5700e1 to
0dbe039
Compare
mitchnielsen
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
mitchnielsen
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
jamiezieziula
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The type change from
jsontypes.Normalizedtotypes.Stringin f613e92 enabled bare Jinja expressions as webhook templates, but we only had test coverage for JSON-wrapped templates. This adds an acceptance test and example for a completely non-JSON template string like{{ body|from_cloud_event(headers) }}, which is the pattern that originally tripped up users in #533.Closes #533
🤖 Generated with Claude Code