-
Notifications
You must be signed in to change notification settings - Fork 25
feat(TaxRulesGroup): Add partial update on status #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Kaikina
commented
Dec 3, 2025
| Questions | Answers |
|---|---|
| Description? | Add partial update for tax rules group on status property (enabled) |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | NA |
| Sponsor company | Evolutive |
| How to test? | Try via the swagger doc to edit the status of an existing tax rule group. Switch it to disabled then enabled. |
|
Hello @Kaikina! This is your first pull request on ps_apiresources repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
|
Hello @Kaikina As visible in the CI, the name you chose for one of the endpoints is invalid, it didn’t follow requirements from ADR. Could you make sure to fix it? |
kpodemski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking since CI is red, details in the message above.
I can change it, but that's kind of a weird issue I think, as the endpoint is not to update several statuses but only one |
|
cc @jolelievre |
|
I think the problem is that the path corresponding to this CQRS command cannot fully respect the REST approach, as this patch method directs the user to the update of one specific property. |