Use gRPC server to validate NEX token instead of local validation#61
Open
Use gRPC server to validate NEX token instead of local validation#61
Conversation
4 tasks
DaniElectra
requested changes
Jan 20, 2026
makes it more clear that the logic is specific to our services
DaniElectra
reviewed
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #XXX
Changes:
Makes the following changes:
ValidatePretendoLoginDatatoValidateNEXLoginDatafor clarity on what kind of data is being validated (and also removes the branding issue of not having "Network" in the name, without making the function name too long)SetPretendoValidationtoSetGameServerIDfor clarity on what the value is that's actually being set. The game server ID is tied to tokens on the account server, so sending it allows the account server to know that the token was issued for the requesting game serverID1,ID2,ID3and the server splits them). Changing the gRPC protobufs to allow multiple game server IDs is the cleanest option imo, and I would prefer making it a real array field, but keeping it as a single string that gets split on the server is also fine and would mean less API changesDo not merge this yet even if approved. Needs PretendoNetwork/account#313 to be both merged AND deployed to work