Skip to content

Conversation

@mikasenghaas
Copy link
Member

@mikasenghaas mikasenghaas commented Oct 5, 2025

Description

Fixes #432.

uv run vf-eval hle -n 1 -r 1 -t 1

On current main there is no prompt (this is due to messages_to_printable, otherwise it would be this weird Pydantic iterator validation)

Screenshot 2025-10-06 at 10 34 43 AM

On this PR we get the prompt as expected.

Screenshot 2025-10-06 at 10 34 06 AM

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test improvement

Testing

  • All existing tests pass when running uv run pytest locally.
  • New tests have been added to cover the changes

Checklist

  • My code follows the style guidelines of this project as outlined in AGENTS.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Additional Notes

@mikasenghaas mikasenghaas force-pushed the mika/fix/multimodal-prompts branch from bf201c8 to 26bb104 Compare October 6, 2025 08:41
@mikasenghaas mikasenghaas marked this pull request as ready for review October 6, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pydantic model doesn't play nicely with OAI union of typed dicts

2 participants