Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update downloads page #597

Merged
merged 9 commits into from
Jan 3, 2025
Merged

update downloads page #597

merged 9 commits into from
Jan 3, 2025

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Oct 21, 2024 •
edited
Loading

  • chore(package.json): don't use npx where it's not needed
  • chore(nix): flake.nix -> shell.nix
  • feat(download): update and clean linux download page
  • feat(download): split official and community linux packages
  • feat(download): cleanup windows section; mark winget as official
  • chore(download): document nix installation option for macos; cleanup

@netlify Netlify
Copy link

netlify bot commented Oct 21, 2024 •
edited
Loading

✅ Deploy Preview for prismlauncher ready!

Name Link
🔨 Latest commit 827150d
🔍 Latest deploy log https://app.netlify.com/sites/prismlauncher/deploys/6777a89cf194400008cafdbe
😎 Deploy Preview https://deploy-preview-597--prismlauncher.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

This was referenced Oct 24, 2024
Merged
Merged
@getchoo getchoo marked this pull request as ready for review October 29, 2024 04:50
@getchoo
Copy link
Member Author

getchoo commented Oct 29, 2024

CC @Scrumplex for Nix changes

@getchoo
Copy link
Member Author

getchoo commented Oct 29, 2024

#637 has also split off from this to improve build docs

@theofficialgman
Copy link
Contributor

Might be worth noting the appimage is x86_64 only under the official packages category.

TayouVR
TayouVR approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@TayouVR TayouVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@getchoo getchoo changed the title update downloads page and build instructions update downloads page Oct 29, 2024
getchoo added 3 commits January 1, 2025 20:37
@getchoo
chore(package.json): don't use npx where it's not needed
e1299e7
@getchoo
chore(nix): flake.nix -> shell.nix
e5a3698 
We don't really leverage Flakes here, and the lockfile is horribly
outdated. A shell.nix should be fine
@getchoo
feat(download): update and clean linux download page
20ee07a 
Some packages don't exist any more, some things can be better worded or
link to external documentation
@getchoo getchoo marked this pull request as draft January 2, 2025 01:59
@getchoo getchoo marked this pull request as ready for review January 2, 2025 01:59
@getchoo getchoo requested a review from TayouVR January 2, 2025 02:00
TayouVR
TayouVR approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@TayouVR TayouVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only found one minor nitpick, lgtm

src/download/linux.md Outdated Show resolved Hide resolved
@getchoo getchoo requested a review from TayouVR January 3, 2025 09:06
@TayouVR TayouVR merged commit 9c745b6 into PrismLauncher:main Jan 3, 2025
5 checks passed
@getchoo getchoo mentioned this pull request Jan 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TayouVR TayouVR TayouVR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@getchoo @theofficialgman @TayouVR