This repository was archived by the owner on Jan 9, 2024. It is now read-only.
Housekeeping #12
Merged
Housekeeping #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename base module from 'Strings' to 'MCSP'.
Rename test binary to 'test', benchmark binary to 'bench' and place 'test-lib' inside the 'MCSP' module.
Rename package and main library to 'mcsp-algorithms'. Also, updates description and bump version to 0.0.2.
Split 'hie.yaml' into multiple files, with specific configurations for tests and benchmarks. Fix for haskell/haskell-language-server#366
Move 'Partition' type to 'String.Extra' and random generation to 'TestLib.Random'.
Move 'System.Random' to 'TestLib', as only tests and benchmarks need randomized values.
Bypass 'body-min-length' by allowing commit messages with empty bodies.
Reduce line length from 120 to 100 throughout the repository.
Update comma-style from 'leading' (default) to 'trailing' in Haskell files, to match the pattern used in other languages. See https://fourmolu.github.io/config/comma-style/
marmitar
force-pushed
the
chore/renaming
branch
from
80c1467 to
b452457
Compare
Use a simpler GADT syntax (without 'where') for 'String' definition.
marmitar
force-pushed
the
chore/renaming
branch
from
b452457 to
04ddb55
Compare
leonardosrodrigues0
approved these changes
Aug 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Housekeeping
This PR doesn't add any new features. Instead, it revisits and updates multiple decisions made early in the project. The changes include:
MCSP.hie.yamlas a fix forCould not load module/Cannot satisfy -packageerror for exe/test/bench component whose main lib doesn't build or was not built haskell/haskell-language-server#366.RandomtoTestLib.It is recommended to erase
.stack-workanddist-newstyleand use a fresh build for these new changes.